From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <felipe.balbi@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] omap: mmc: fix compile breakage on board-n800-mmc.c
Date: Mon, 6 Oct 2008 12:21:38 +0300 [thread overview]
Message-ID: <20081006092137.GB2806@atomide.com> (raw)
In-Reply-To: <1223284162-7511-1-git-send-email-felipe.balbi@nokia.com>
* Felipe Balbi <felipe.balbi@nokia.com> [081006 12:10]:
> Commit 81d2c7d87a9c1eb724788fce7312922effa1b1ae broke
> compilation of board-n800-mmc.c, this patch fixes it.
Thanks, pushing.
> Still n810 doesn't boot anymore with current linux-omap.
> Will look into that soon.
Could it be because of the removal of the 0 byte I2C hack?
Tony
>
> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
> arch/arm/mach-omap2/board-n800-mmc.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-n800-mmc.c b/arch/arm/mach-omap2/board-n800-mmc.c
> index 2cf8213..2c5c97c 100644
> --- a/arch/arm/mach-omap2/board-n800-mmc.c
> +++ b/arch/arm/mach-omap2/board-n800-mmc.c
> @@ -336,7 +336,7 @@ void __init n800_mmc_init(void)
>
> {
> if (machine_is_nokia_n810()) {
> - n800_mmc1_data.slots[0].name = "external";
> + mmc1_data.slots[0].name = "external";
>
> /*
> * Some Samsung Movinand chips do not like open-ended
> @@ -344,8 +344,8 @@ void __init n800_mmc_init(void)
> * while doing so. Reducing the number of blocks in
> * the transfer or delays in clock disable do not help
> */
> - n800_mmc1_data.slots[1].name = "internal";
> - n800_mmc1_data.slots[1].ban_openended = 1;
> + mmc1_data.slots[1].name = "internal";
> + mmc1_data.slots[1].ban_openended = 1;
> }
>
> if (omap_request_gpio(slot_switch_gpio) < 0)
> --
> 1.6.0.2.307.gc427
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-10-06 9:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-06 9:09 [PATCH] omap: mmc: fix compile breakage on board-n800-mmc.c Felipe Balbi
2008-10-06 9:21 ` Tony Lindgren [this message]
2008-10-06 9:25 ` Felipe Balbi
2008-10-06 10:32 ` Jarkko Nikula
2008-10-06 11:49 ` Felipe Balbi
2008-10-06 12:22 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081006092137.GB2806@atomide.com \
--to=tony@atomide.com \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).