From: David Brownell <david-b@pacbell.net>
To: Paul Walmsley <paul@pwsan.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] alsa: add Beagleboard SoC configuration.
Date: Mon, 6 Oct 2008 11:01:53 -0700 [thread overview]
Message-ID: <200810061101.54350.david-b@pacbell.net> (raw)
In-Reply-To: <alpine.DEB.2.00.0810060906140.354@utopia.booyaka.com>
On Monday 06 October 2008, Paul Walmsley wrote:
> > [ INFO: possible recursive locking detected ]
> > 2.6.27-rc8-omap1 #174
> > ---------------------------------------------
> > aplay/1816 is trying to acquire lock:
> > (clockfw_lock){....}, at: [<c0036be4>] clk_enable+0x24/0x70
> >
> > but task is already holding lock:
> > (clockfw_lock){....}, at: [<c0036be4>] clk_enable+0x24/0x70
>
> Yeah, the code that's in that driver is broken. The driver
> sets up a custom clk_enable() function that calls clk_enable() again. And
> clk_enable() takes clockfw_lock.
I don't follow. Could you point at those lines of code?
The only clkfw_lock I see is in plat-omap/clock.c code ...
which isn't part of this ASoC driver or even its board glue.
> The omap_clk_associate() code should resolve this problem.
Time to resolve that, then... are you saying that the patches
Felipe posted will, if merged, make this lockdep report go
away so it's safe to run lockdep and ALSA on twl4030 codecs?
- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-10-06 18:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-16 20:51 [PATCH] alsa: add Beagleboard SoC configuration Felipe Contreras
2008-09-17 6:19 ` Jarkko Nikula
2008-09-17 12:15 ` Steve Sakoman
2008-10-04 6:34 ` David Brownell
2008-10-06 15:09 ` Paul Walmsley
2008-10-06 18:01 ` David Brownell [this message]
2008-10-06 18:32 ` Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2008-10-22 16:28 [PATCH] alsa: add beagleboard " Felipe Contreras
2008-10-22 16:53 ` Tony Lindgren
2008-10-22 19:36 ` David Brownell
2008-10-22 20:30 ` Steve Sakoman
2008-10-22 20:44 ` Mark Brown
2008-10-30 11:45 ` Mark Brown
2008-10-30 13:14 ` Steve Sakoman
2008-10-22 19:09 ` David Brownell
2008-10-24 19:03 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810061101.54350.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=felipe.contreras@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox