Re: [PATCH 3/3] lp5521: move to drivers/leds

[Tony Lindgren <tony@atomide.com>]

* Riku Voipio <riku.voipio@iki.fi> [081006 14:09]:
> On Mon, Oct 06, 2008 at 12:11:31PM +0300, Felipe Balbi wrote:
> > This driver should be sitting together with the other
> > led drivers.
> 
> But this driver actually doesn't implement the led sysfs interface.
> If the driver is changed to implement the led framework interface,
> we break the existing n810 userland and expose only limited subset
> of lp5521 features for userland..

Maybe this feature should be a distro specific hack on top of
the mainline tree?

Tony

> > Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> > ---
> >  drivers/i2c/chips/Kconfig                          |    7 -------
> >  drivers/i2c/chips/Makefile                         |    1 -
> >  drivers/leds/Kconfig                               |    7 +++++++
> >  drivers/leds/Makefile                              |    1 +
> >  drivers/{i2c/chips/lp5521.c => leds/leds-lp5521.c} |    0
> >  5 files changed, 8 insertions(+), 8 deletions(-)
> >  rename drivers/{i2c/chips/lp5521.c => leds/leds-lp5521.c} (100%)
> > 
> > diff --git a/drivers/i2c/chips/Kconfig b/drivers/i2c/chips/Kconfig
> > index e6ac6a2..1b9bc11 100644
> > --- a/drivers/i2c/chips/Kconfig
> > +++ b/drivers/i2c/chips/Kconfig
> > @@ -225,13 +225,6 @@ config SENSORS_TSL2563
> >           This driver can also be built as a module.  If so, the module
> >           will be called tsl2563.
> >  
> > -config LP5521
> > -	tristate "LP5521 LED driver chip"
> > -	depends on I2C
> > -	help
> > -	  If you say yes here you get support for the National Semiconductor
> > -	  LP5521 LED driver.
> > -
> >  config MENELAUS
> >  	bool "TWL92330/Menelaus PM chip"
> >  	depends on I2C=y && ARCH_OMAP24XX
> > diff --git a/drivers/i2c/chips/Makefile b/drivers/i2c/chips/Makefile
> > index 75c531a..7523e58 100644
> > --- a/drivers/i2c/chips/Makefile
> > +++ b/drivers/i2c/chips/Makefile
> > @@ -30,7 +30,6 @@ obj-$(CONFIG_TWL4030_POWEROFF)	+= twl4030-poweroff.o
> >  obj-$(CONFIG_TWL4030_PWRBUTTON)	+= twl4030-pwrbutton.o
> >  obj-$(CONFIG_TWL4030_MADC)	+= twl4030-madc.o
> >  obj-$(CONFIG_RTC_X1205_I2C)	+= x1205.o
> > -obj-$(CONFIG_LP5521)		+= lp5521.o
> >  
> >  ifeq ($(CONFIG_I2C_DEBUG_CHIP),y)
> >  EXTRA_CFLAGS += -DDEBUG
> > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> > index 6a2f441..bd7c4dc 100644
> > --- a/drivers/leds/Kconfig
> > +++ b/drivers/leds/Kconfig
> > @@ -146,6 +146,13 @@ config LEDS_CM_X270
> >  	help
> >  	  This option enables support for the CM-X270 LEDs.
> >  
> > +config LEDS_LP5521
> > +	tristate "LED Support for LP5521 RGB LEDs"
> > +	depends on LEDS_CLASS && I2C
> > +	help
> > +	  If you say yes here you get support for the National Semiconductor
> > +	  LP5521 LED driver used in n8x0 boards.
> > +
> >  config LEDS_CLEVO_MAIL
> >  	tristate "Mail LED on Clevo notebook (EXPERIMENTAL)"
> >  	depends on LEDS_CLASS && X86 && SERIO_I8042 && DMI && EXPERIMENTAL
> > diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile
> > index fd6316e..ce5c8cd 100644
> > --- a/drivers/leds/Makefile
> > +++ b/drivers/leds/Makefile
> > @@ -21,6 +21,7 @@ obj-$(CONFIG_LEDS_COBALT_RAQ)		+= leds-cobalt-raq.o
> >  obj-$(CONFIG_LEDS_PCA9532)		+= leds-pca9532.o
> >  obj-$(CONFIG_LEDS_GPIO)			+= leds-gpio.o
> >  obj-$(CONFIG_LEDS_CM_X270)              += leds-cm-x270.o
> > +obj-$(CONFIG_LEDS_LP5521)		+= leds-lp5521.o
> >  obj-$(CONFIG_LEDS_CLEVO_MAIL)		+= leds-clevo-mail.o
> >  obj-$(CONFIG_LEDS_HP6XX)		+= leds-hp6xx.o
> >  obj-$(CONFIG_LEDS_FSG)			+= leds-fsg.o
> > diff --git a/drivers/i2c/chips/lp5521.c b/drivers/leds/leds-lp5521.c
> > similarity index 100%
> > rename from drivers/i2c/chips/lp5521.c
> > rename to drivers/leds/leds-lp5521.c
> > -- 
> > 1.6.0.2.307.gc427
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> -- 
> "rm -rf" only sounds scary if you don't have backups
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html