public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <me@felipebalbi.com>
To: "Gadiyar, Anand" <gadiyar@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"tony@atomide.com" <tony@atomide.com>
Subject: Re: Compilation broken for 3430SDP defconfig
Date: Mon, 6 Oct 2008 18:47:20 +0300	[thread overview]
Message-ID: <20081006154716.GA8273@frodo> (raw)
In-Reply-To: <5A47E75E594F054BAF48C5E4FC4B92AB02D6107644@dbde02.ent.ti.com>

On Mon, Oct 06, 2008 at 09:14:19PM +0530, Gadiyar, Anand wrote:
> CONFIG_GPIO_TWL4030 needs to be set in menuconfig otherwise,
> for OMAP3 defconfig we get the below build error.
> 
> arch/arm/mach-omap2/built-in.o: In function `hsmmc_card_detect':
> /share/anand/tony/arch/arm/mach-omap2/hsmmc.c:50: undefined reference to `twl4030_get_gpio_datain'
> arch/arm/mach-omap2/built-in.o: In function `hsmmc_cleanup':
> /share/anand/tony/arch/arm/mach-omap2/hsmmc.c:82: undefined reference to `twl4030_free_gpio'
> arch/arm/mach-omap2/built-in.o: In function `hsmmc_late_init':
> /share/anand/tony/arch/arm/mach-omap2/hsmmc.c:63: undefined reference to `twl4030_request_gpio'
> /share/anand/tony/arch/arm/mach-omap2/hsmmc.c:67: undefined reference to `twl4030_set_gpio_debounce'
> make: *** [.tmp_vmlinux1] Error 1

Yes, we need defconfig changes since Kconfig is not asking about the new
CONFIG_GPIO_TWL4030 symbol added.

That'll probably change soon when we start using standard gpio calls but
please, provide the defconfig change. You could even do it for all omap3
plus 2430.

-- 
balbi

  reply	other threads:[~2008-10-06 15:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-06 15:44 Compilation broken for 3430SDP defconfig Gadiyar, Anand
2008-10-06 15:47 ` Felipe Balbi [this message]
2008-10-06 15:53   ` Gadiyar, Anand
2008-10-06 16:41   ` David Brownell
2008-10-06 18:20     ` Aguirre Rodriguez, Sergio Alberto
2008-10-06 18:25       ` Aguirre Rodriguez, Sergio Alberto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081006154716.GA8273@frodo \
    --to=me@felipebalbi.com \
    --cc=gadiyar@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox