Compilation broken for 3430SDP defconfig

Compilation broken for 3430SDP defconfig

[Gadiyar, Anand]

CONFIG_GPIO_TWL4030 needs to be set in menuconfig otherwise,
for OMAP3 defconfig we get the below build error.

arch/arm/mach-omap2/built-in.o: In function `hsmmc_card_detect':
/share/anand/tony/arch/arm/mach-omap2/hsmmc.c:50: undefined reference to `twl4030_get_gpio_datain'
arch/arm/mach-omap2/built-in.o: In function `hsmmc_cleanup':
/share/anand/tony/arch/arm/mach-omap2/hsmmc.c:82: undefined reference to `twl4030_free_gpio'
arch/arm/mach-omap2/built-in.o: In function `hsmmc_late_init':
/share/anand/tony/arch/arm/mach-omap2/hsmmc.c:63: undefined reference to `twl4030_request_gpio'
/share/anand/tony/arch/arm/mach-omap2/hsmmc.c:67: undefined reference to `twl4030_set_gpio_debounce'
make: *** [.tmp_vmlinux1] Error 1

Re: Compilation broken for 3430SDP defconfig

[Felipe Balbi]

On Mon, Oct 06, 2008 at 09:14:19PM +0530, Gadiyar, Anand wrote:
> CONFIG_GPIO_TWL4030 needs to be set in menuconfig otherwise,
> for OMAP3 defconfig we get the below build error.
> 
> arch/arm/mach-omap2/built-in.o: In function `hsmmc_card_detect':
> /share/anand/tony/arch/arm/mach-omap2/hsmmc.c:50: undefined reference to `twl4030_get_gpio_datain'
> arch/arm/mach-omap2/built-in.o: In function `hsmmc_cleanup':
> /share/anand/tony/arch/arm/mach-omap2/hsmmc.c:82: undefined reference to `twl4030_free_gpio'
> arch/arm/mach-omap2/built-in.o: In function `hsmmc_late_init':
> /share/anand/tony/arch/arm/mach-omap2/hsmmc.c:63: undefined reference to `twl4030_request_gpio'
> /share/anand/tony/arch/arm/mach-omap2/hsmmc.c:67: undefined reference to `twl4030_set_gpio_debounce'
> make: *** [.tmp_vmlinux1] Error 1

Yes, we need defconfig changes since Kconfig is not asking about the new
CONFIG_GPIO_TWL4030 symbol added.

That'll probably change soon when we start using standard gpio calls but
please, provide the defconfig change. You could even do it for all omap3
plus 2430.

-- 
balbi

RE: Compilation broken for 3430SDP defconfig

[Gadiyar, Anand]

> -----Original Message-----
> From: Felipe Balbi [mailto:me@felipebalbi.com] 
> On Mon, Oct 06, 2008 at 09:14:19PM +0530, Gadiyar, Anand wrote:
> > CONFIG_GPIO_TWL4030 needs to be set in menuconfig otherwise,
> > for OMAP3 defconfig we get the below build error.
> > 
> > arch/arm/mach-omap2/built-in.o: In function `hsmmc_card_detect':
> > /share/anand/tony/arch/arm/mach-omap2/hsmmc.c:50: undefined reference to `twl4030_get_gpio_datain'
> > arch/arm/mach-omap2/built-in.o: In function `hsmmc_cleanup':
> > /share/anand/tony/arch/arm/mach-omap2/hsmmc.c:82: undefined reference to `twl4030_free_gpio'
> > arch/arm/mach-omap2/built-in.o: In function `hsmmc_late_init':
> > /share/anand/tony/arch/arm/mach-omap2/hsmmc.c:63: undefined reference to `twl4030_request_gpio'
> > /share/anand/tony/arch/arm/mach-omap2/hsmmc.c:67: undefined reference to `twl4030_set_gpio_debounce'
> > make: *** [.tmp_vmlinux1] Error 1
> 
> Yes, we need defconfig changes since Kconfig is not asking about the new
> CONFIG_GPIO_TWL4030 symbol added.
> 
> That'll probably change soon when we start using standard gpio calls but
> please, provide the defconfig change. You could even do it for all omap3
> plus 2430.

Will it help if we have a 'default' option in drivers/gpio/Kconfig?

Something like:
+	default y if ARCH_OMAP34XX || MACH_OMAP_2430SDP

Re: Compilation broken for 3430SDP defconfig

[David Brownell]

On Monday 06 October 2008, Felipe Balbi wrote:
> Yes, we need defconfig changes since Kconfig is not asking about the new
> CONFIG_GPIO_TWL4030 symbol added.

I seem to have tested with "make oldconfig" not "make ..._defconfig".

RE: Compilation broken for 3430SDP defconfig

[Aguirre Rodriguez, Sergio Alberto]

Hi all,

Today I did a pull from the linux-omap tree, and I have this error in compilation with the sdp defconfig:

  CC      arch/arm/mach-omap2/board-3430sdp.o
arch/arm/mach-omap2/board-3430sdp.c:43:35: error: linux/i2c/twl4030-rtc.h: No such file or directory
arch/arm/mach-omap2/board-3430sdp.c: In function 'msecure_init':
arch/arm/mach-omap2/board-3430sdp.c:132: warning: initialization makes integer from pointer without a cast
make[1]: *** [arch/arm/mach-omap2/board-3430sdp.o] Error 1
make: *** [arch/arm/mach-omap2] Error 2

So, I just did a git pull, then a git gc. I'm not seeing that linux/i2c/twl4030-rtc.h file now. Has someone moved it? Or do you think it could be something related to my clone?

Regards,
Sergio

> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of David Brownell
> Sent: Monday, October 06, 2008 11:42 AM
> To: me@felipebalbi.com
> Cc: Gadiyar, Anand; linux-omap@vger.kernel.org; tony@atomide.com
> Subject: Re: Compilation broken for 3430SDP defconfig
>
> On Monday 06 October 2008, Felipe Balbi wrote:
> > Yes, we need defconfig changes since Kconfig is not asking about the new
> > CONFIG_GPIO_TWL4030 symbol added.
>
> I seem to have tested with "make oldconfig" not "make ..._defconfig".
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: Compilation broken for 3430SDP defconfig

[Aguirre Rodriguez, Sergio Alberto]

Ok, I just noticed from the mails what happened.. :)

Sorry for the unnecessary alert.
> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of Aguirre Rodriguez, Sergio Alberto
> Sent: Monday, October 06, 2008 1:20 PM
> To: David Brownell; me@felipebalbi.com
> Cc: Gadiyar, Anand; linux-omap@vger.kernel.org; tony@atomide.com
> Subject: RE: Compilation broken for 3430SDP defconfig
>
> Hi all,
>
> Today I did a pull from the linux-omap tree, and I have this error in
> compilation with the sdp defconfig:
>
>   CC      arch/arm/mach-omap2/board-3430sdp.o
> arch/arm/mach-omap2/board-3430sdp.c:43:35: error: linux/i2c/twl4030-rtc.h:
> No such file or directory
> arch/arm/mach-omap2/board-3430sdp.c: In function 'msecure_init':
> arch/arm/mach-omap2/board-3430sdp.c:132: warning: initialization makes
> integer from pointer without a cast
> make[1]: *** [arch/arm/mach-omap2/board-3430sdp.o] Error 1
> make: *** [arch/arm/mach-omap2] Error 2
>
> So, I just did a git pull, then a git gc. I'm not seeing that
> linux/i2c/twl4030-rtc.h file now. Has someone moved it? Or do you think it
> could be something related to my clone?
>
> Regards,
> Sergio
>
> > -----Original Message-----
> > From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> > owner@vger.kernel.org] On Behalf Of David Brownell
> > Sent: Monday, October 06, 2008 11:42 AM
> > To: me@felipebalbi.com
> > Cc: Gadiyar, Anand; linux-omap@vger.kernel.org; tony@atomide.com
> > Subject: Re: Compilation broken for 3430SDP defconfig
> >
> > On Monday 06 October 2008, Felipe Balbi wrote:
> > > Yes, we need defconfig changes since Kconfig is not asking about the
> new
> > > CONFIG_GPIO_TWL4030 symbol added.
> >
> > I seem to have tested with "make oldconfig" not "make ..._defconfig".
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html