Re: DVB-T problems with MUSB

[David Brownell <david-b@pacbell.net>]

On Tuesday 07 October 2008, Kimmo Jukarainen wrote:
> On Tue, Oct 07, 2008 at 09:03:42PM +0200, Koen Kooi wrote:
> > Is this a problem with MUSB, omap dma or the dvb stack?
> 
> I'd say dvb stack. This small patch fixed my dvb-t stick with
> a omap2 board:
> 
> http://www.linuxtv.org/pipermail/linux-dvb/2008-January/023040.html

Looks like a fair fix, at a quick look.

I'm kind of surprised that bug has been known for what
looks like about a year now, with a trivial fix that
hasn't yet been merged through the DVB tree ...


> --- linux-2.6.20.4.orig/drivers/media/dvb/dvb-usb/usb-urb.c 2007-03-23 20:52:51.000000000 +0100
> +++ linux-2.6.20.4/drivers/media/dvb/dvb-usb/usb-urb.c 2007-10-25 12:19:50.000000000 +0200
> @@ -152,7 +152,8 @@
>  	stream->props.u.bulk.buffersize,
>  	usb_urb_complete, stream);
>
> -	stream->urb_list[i]->transfer_flags = 0;
> +	stream->urb_list[i]->transfer_flags = URB_NO_TRANSFER_DMA_MAP;
> +	stream->urb_list[i]->transfer_dma = stream->dma_addr[i];
>  	stream->urbs_initialized++;
>  }
>  return 0;