Re: [PATCH 2.6.27-rc9-omap] i2c-omap: timeouts begone

[Felipe Balbi <me@felipebalbi.com>]

On Wed, Oct 08, 2008 at 02:36:05PM -0700, David Brownell wrote:
> I can tell someone's going to want a fix that's a
> lot more power-aware ... ;)
> 
> This seems to remove the need for the "hack" patch.
> 
> 
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -202,6 +202,9 @@ static void omap_i2c_put_clocks(struct omap_i2c_dev *dev)
>  
>  static void omap_i2c_unidle(struct omap_i2c_dev *dev)
>  {
> +	if (1)
> +		return;
> +
>  	if (dev->iclk != NULL)
>  		clk_enable(dev->iclk);
>  	clk_enable(dev->fclk);
> @@ -214,6 +217,9 @@ static void omap_i2c_idle(struct omap_i2c_dev *dev)
>  {
>  	u16 iv;
>  
> +	if (1)
> +		return;
> +
>  	dev->iestate = omap_i2c_read_reg(dev, OMAP_I2C_IE_REG);
>  	omap_i2c_write_reg(dev, OMAP_I2C_IE_REG, 0);
>  	if (dev->rev1)


At least we can say the problem seems to be related to pm. Maybe after
context restore we should wait until the clock stabilizes or some
register changes ??

-- 
balbi