From: David Brownell <david-b@pacbell.net>
To: me@felipebalbi.com
Cc: Felipe Balbi <felipe.balbi@nokia.com>,
linux-omap@vger.kernel.org, Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH 3/8] lp5521: move to drivers/leds
Date: Tue, 14 Oct 2008 10:19:52 -0700 [thread overview]
Message-ID: <200810141019.52997.david-b@pacbell.net> (raw)
In-Reply-To: <20081014171102.GI20247@frodo>
On Tuesday 14 October 2008, Felipe Balbi wrote:
> On Tue, Oct 14, 2008 at 08:53:28AM -0700, David Brownell wrote:
> > On Tuesday 14 October 2008, Felipe Balbi wrote:
> > > This driver should be sitting together with the other
> > > led drivers.
> >
> > ... iff it actually uses the LED framework. Which it
> > doesn't, yet, even for simple operations.
>
> Should I change the order of the patches ? The patch going to Richard is
> only the final version of it, so there wouldn't be any difference for
> him I'd say.
The rule of thumb is to preserve bisectability. That may be less
important inside the OMAP tree. The sequencing is fine, but it'd
be less confusing to patch-at-a-time review to at least see the
comment that a *later* patch makes it use the LED framework.
- Dave
next prev parent reply other threads:[~2008-10-14 17:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-14 13:01 [PATCH 0/8] updtes to few nokia drivers Felipe Balbi
2008-10-14 13:01 ` [PATCH 1/8] i2c: lp5521: remove dead code Felipe Balbi
2008-10-14 13:01 ` [PATCH 2/8] i2c: lp5521: cosmetic fixes Felipe Balbi
2008-10-14 13:01 ` [PATCH 3/8] lp5521: move to drivers/leds Felipe Balbi
2008-10-14 13:01 ` [PATCH 4/8] leds: lp5521: simplify mode setting Felipe Balbi
2008-10-14 13:01 ` [PATCH 5/8] leds: lp5521: register separate leds Felipe Balbi
2008-10-14 13:01 ` [PATCH 6/8] tsl2563: move tsl2563 to drivers/hwmon Felipe Balbi
2008-10-14 13:01 ` [PATCH 7/8] input: lm8323: get rid of global pdata pointer Felipe Balbi
2008-10-14 13:01 ` [PATCH 8/8] input: tsc2005: move to gpiolib Felipe Balbi
2008-10-14 13:38 ` [PATCH 6/8] tsl2563: move tsl2563 to drivers/hwmon Jean Delvare
2008-10-14 13:52 ` Felipe Balbi
2008-10-14 14:14 ` Jean Delvare
2008-10-14 14:38 ` Felipe Balbi
2008-10-14 16:00 ` David Brownell
2008-10-14 21:20 ` Felipe Balbi
2008-10-14 21:44 ` David Brownell
2008-10-14 21:50 ` Felipe Balbi
2008-10-15 8:26 ` Jean Delvare
2008-10-14 15:55 ` [PATCH 5/8] leds: lp5521: register separate leds David Brownell
2008-10-14 17:09 ` Felipe Balbi
2008-10-14 15:53 ` [PATCH 3/8] lp5521: move to drivers/leds David Brownell
2008-10-14 17:11 ` Felipe Balbi
2008-10-14 17:19 ` David Brownell [this message]
2008-10-14 17:32 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810141019.52997.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox