From: David Brownell <david-b@pacbell.net>
To: Peter 'p2' De Schrijver <peter.de-schrijver@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 3/7] Twl4030 power code updated for new twl4030 core
Date: Tue, 14 Oct 2008 10:38:32 -0700 [thread overview]
Message-ID: <200810141038.32966.david-b@pacbell.net> (raw)
In-Reply-To: <1223912652-24463-4-git-send-email-peter.de-schrijver@nokia.com>
On Monday 13 October 2008, Peter 'p2' De Schrijver wrote:
> ---
> drivers/mfd/twl4030-power.c | 270 +++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 270 insertions(+), 0 deletions(-)
I tend to agree with the comment from Felipe that moving
this file from i2c/chips to mfd should be one patch.
Again, the general rule about such stuff is that a patch
series should preserve bisectability. Else it gets hard
to use "git bisect" to track down particularly pernicious
problem patterns, promptly puncturing perplexing puzzles.
:)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-10-14 17:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 15:44 [PATCH 0/7] Integrate the twl4030 power code into new twl4030 mfd Peter 'p2' De Schrijver
2008-10-13 15:44 ` [PATCH 1/7] Remove existing twl4030 power script code Peter 'p2' De Schrijver
2008-10-13 15:44 ` [PATCH 2/7] Add defines and data types for twl4030 Peter 'p2' De Schrijver
2008-10-13 15:44 ` [PATCH 3/7] Twl4030 power code updated for new twl4030 core Peter 'p2' De Schrijver
2008-10-13 15:44 ` [PATCH 4/7] Hook twl4030 power code into " Peter 'p2' De Schrijver
2008-10-13 15:44 ` [PATCH 5/7] 3430sdp and ldp use custom twl4030 power scripts Peter 'p2' De Schrijver
2008-10-13 15:44 ` [PATCH 6/7] Generic twl4030 power script for 3430 based boards Peter 'p2' De Schrijver
2008-10-13 15:44 ` [PATCH 7/7] omap3 evm, beagle and overo use the generic twl4030 script Peter 'p2' De Schrijver
2008-10-14 17:42 ` [PATCH 4/7] Hook twl4030 power code into twl4030 core David Brownell
2008-10-14 17:38 ` David Brownell [this message]
2008-10-14 17:44 ` [PATCH 0/7] Integrate the twl4030 power code into new twl4030 mfd David Brownell
-- strict thread matches above, loose matches on Subject: below --
2008-10-10 16:56 Peter 'p2' De Schrijver
2008-10-10 16:56 ` [PATCH 1/7] Remove existing twl4030 power script code Peter 'p2' De Schrijver
2008-10-10 16:56 ` [PATCH 2/7] Add defines and data types for twl4030 Peter 'p2' De Schrijver
2008-10-10 16:56 ` [PATCH 3/7] Twl4030 power code updated for new twl4030 core Peter 'p2' De Schrijver
2008-10-11 18:49 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810141038.32966.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
--cc=peter.de-schrijver@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox