From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: madhu.cr@ti.com, gadiyar@ti.com, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/5] HDQ Driver for OMAP2430/3430
Date: Tue, 14 Oct 2008 18:55:34 +0400 [thread overview]
Message-ID: <20081014145534.GA22732@2ka.mipt.ru> (raw)
In-Reply-To: <20081014073058.e5d972e6.akpm@linux-foundation.org>
On Tue, Oct 14, 2008 at 07:30:58AM -0700, Andrew Morton (akpm@linux-foundation.org) wrote:
> > Why not just skipping the waiting and returning error pretending user
> > really sent a signal?
>
> Better than nothing, but because signal_pending() isn't actually true,
> upper layers wil behave differently.
If they check...
For example omap_hdq_break() can be interrupted and omap_hdq_probe()
does not check its return value.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2008-10-14 14:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 7:16 [PATCH 1/5] HDQ Driver for OMAP2430/3430 Gadiyar, Anand
2008-10-08 19:59 ` Evgeniy Polyakov
2008-10-10 20:38 ` Andrew Morton
2008-10-13 13:25 ` Madhusudhan Chikkature
2008-10-13 13:42 ` Evgeniy Polyakov
2008-10-13 15:53 ` Andrew Morton
2008-10-14 8:51 ` Madhusudhan Chikkature
2008-10-14 12:50 ` Andrew Morton
2008-10-14 13:42 ` Evgeniy Polyakov
2008-10-14 14:30 ` Andrew Morton
2008-10-14 14:55 ` Evgeniy Polyakov [this message]
2008-10-16 7:05 ` Madhusudhan Chikkature
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081014145534.GA22732@2ka.mipt.ru \
--to=johnpol@2ka.mipt.ru \
--cc=akpm@linux-foundation.org \
--cc=gadiyar@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=madhu.cr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox