Re: [PATCH 6/8] tsl2563: move tsl2563 to drivers/hwmon

[Jean Delvare <khali@linux-fr.org>]

Hi Felipe,

On Tue, 14 Oct 2008 16:01:38 +0300, Felipe Balbi wrote:
> Moving the driver to where it should sit. No functional
> changes.
> 
> Cc: Jean Delvare <khali@linux-fr.org>
> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
>  drivers/hwmon/Kconfig                  |   10 ++++++++++
>  drivers/hwmon/Makefile                 |    1 +
>  drivers/{i2c/chips => hwmon}/tsl2563.c |    2 +-
>  drivers/i2c/chips/Kconfig              |   10 ----------
>  drivers/i2c/chips/Makefile             |    1 -
>  5 files changed, 12 insertions(+), 12 deletions(-)
>  rename drivers/{i2c/chips => hwmon}/tsl2563.c (99%)
> 
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 390c6fa..dabc148 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -670,6 +670,16 @@ config SENSORS_THMC50
>  	  This driver can also be built as a module.  If so, the module
>  	  will be called thmc50.
>  
> +config SENSORS_TSL2563
> +       tristate "Taos TSL2563 ambient light sensor"
> +       depends on I2C && HWMON
> +       help
> +         If you say yes here you get support for the Taos TSL2563
> +         ambient light sensor.
> +
> +         This driver can also be built as a module.  If so, the module
> +         will be called tsl2563.
> +
>  config SENSORS_VIA686A
>  	tristate "VIA686A"
>  	depends on PCI

Nack. Light sensors have nothing to do with hardware monitoring.

The only light sensor driver in the kernel tree at the moment
is drivers/i2c/chips/tsl2550.c. But I'm not very happy with this
either, as my ultimate goal is to delete the drivers/i2c/chips
directory completely. So we should find a new home for light sensors.
Maybe they should go into the new "industrial I/O" subsystem. Or if
not, their own drivers/sensors/light directory.

-- 
Jean Delvare