From: Felipe Balbi <me@felipebalbi.com>
To: David Brownell <david-b@pacbell.net>
Cc: Felipe Balbi <felipe.balbi@nokia.com>,
linux-omap@vger.kernel.org, Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH 5/8] leds: lp5521: register separate leds
Date: Tue, 14 Oct 2008 20:09:32 +0300 [thread overview]
Message-ID: <20081014170931.GH20247@frodo> (raw)
In-Reply-To: <200810140855.21657.david-b@pacbell.net>
On Tue, Oct 14, 2008 at 08:55:21AM -0700, David Brownell wrote:
> On Tuesday 14 October 2008, Felipe Balbi wrote:
> > @@ -23,7 +24,9 @@
> > #include <linux/module.h>
> > #include <linux/init.h>
> > #include <linux/i2c.h>
> > +#include <linux/leds.h>
> > #include <linux/mutex.h>
> > +#include <linux/workqueue.h>
> >
> > #define LP5521_DRIVER_NAME "lp5521"
> >
>
> Ah, *here* it converts to use the LED framework. The patch
> comment should probably focus on that ... "separate leds" is
> just an artifact of that conversion, as I interpret things.
Sure, I'll update and resend tomorrow. The ambient light sensor, I'll
drop from now and leave it pending until we have a good answer for where
it should go.
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-10-14 17:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-14 13:01 [PATCH 0/8] updtes to few nokia drivers Felipe Balbi
2008-10-14 13:01 ` [PATCH 1/8] i2c: lp5521: remove dead code Felipe Balbi
2008-10-14 13:01 ` [PATCH 2/8] i2c: lp5521: cosmetic fixes Felipe Balbi
2008-10-14 13:01 ` [PATCH 3/8] lp5521: move to drivers/leds Felipe Balbi
2008-10-14 13:01 ` [PATCH 4/8] leds: lp5521: simplify mode setting Felipe Balbi
2008-10-14 13:01 ` [PATCH 5/8] leds: lp5521: register separate leds Felipe Balbi
2008-10-14 13:01 ` [PATCH 6/8] tsl2563: move tsl2563 to drivers/hwmon Felipe Balbi
2008-10-14 13:01 ` [PATCH 7/8] input: lm8323: get rid of global pdata pointer Felipe Balbi
2008-10-14 13:01 ` [PATCH 8/8] input: tsc2005: move to gpiolib Felipe Balbi
2008-10-14 13:38 ` [PATCH 6/8] tsl2563: move tsl2563 to drivers/hwmon Jean Delvare
2008-10-14 13:52 ` Felipe Balbi
2008-10-14 14:14 ` Jean Delvare
2008-10-14 14:38 ` Felipe Balbi
2008-10-14 16:00 ` David Brownell
2008-10-14 21:20 ` Felipe Balbi
2008-10-14 21:44 ` David Brownell
2008-10-14 21:50 ` Felipe Balbi
2008-10-15 8:26 ` Jean Delvare
2008-10-14 15:55 ` [PATCH 5/8] leds: lp5521: register separate leds David Brownell
2008-10-14 17:09 ` Felipe Balbi [this message]
2008-10-14 15:53 ` [PATCH 3/8] lp5521: move to drivers/leds David Brownell
2008-10-14 17:11 ` Felipe Balbi
2008-10-14 17:19 ` David Brownell
2008-10-14 17:32 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081014170931.GH20247@frodo \
--to=me@felipebalbi.com \
--cc=david-b@pacbell.net \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox