linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Tony Lindgren <tony@atomide.com>
Cc: twebb <taliaferro62@gmail.com>,
	linux-arm-kernel@lists.arm.linux.org.uk,
	linux-omap@vger.kernel.org
Subject: Re: git pull request for minimal omap3 support one more time
Date: Tue, 14 Oct 2008 19:51:01 +0100	[thread overview]
Message-ID: <20081014185100.GA20627@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20081014171907.GD8150@atomide.com>

On Tue, Oct 14, 2008 at 10:19:08AM -0700, Tony Lindgren wrote:
> * Russell King - ARM Linux <linux@arm.linux.org.uk> [081013 09:15]:
> > There's something wrong with one of the sets I've pulled from you:
> > 
> > arch/arm/mach-omap2/mcbsp.c:253: error: ???INT_24XX_MCBSP3_IRQ_RX??? undeclared here (not in a function)
> > arch/arm/mach-omap2/mcbsp.c:254: error: ???INT_24XX_MCBSP3_IRQ_TX??? undeclared here (not in a function)
> > arch/arm/mach-omap2/mcbsp.c:262: error: ???INT_24XX_MCBSP4_IRQ_RX??? undeclared here (not in a function)
> > arch/arm/mach-omap2/mcbsp.c:263: error: ???INT_24XX_MCBSP4_IRQ_TX??? undeclared here (not in a function)
> > arch/arm/mach-omap2/mcbsp.c:271: error: ???INT_24XX_MCBSP5_IRQ_RX??? undeclared here (not in a function)
> > arch/arm/mach-omap2/mcbsp.c:272: error: ???INT_24XX_MCBSP5_IRQ_TX??? undeclared here (not in a function)
> > 
> > Please take a look and resolve ASAP.  Thanks.
> 
> Sorry for the delay, I was sitting in an airplane again.
> 
> Here's the fix, looks like the missing McBSP irqs should have been
> merged into the recent McBSP patches.
> 
> This patch is also in your patch system as 5301/1.

Thanks, that solved that problem, but there's one more to come:

arch/arm/plat-omap/devices.c: In function 'omap_mcbsp_register_board_cfg':
arch/arm/plat-omap/devices.c:163: error: 'OMAP_MAX_MCBSP_COUNT' undeclared (first use in this function)
arch/arm/plat-omap/devices.c:163: error: (Each undeclared identifier is reported only once
arch/arm/plat-omap/devices.c:163: error: for each function it appears in.)

The good news is that that seems to be the last error building for LDP.

  reply	other threads:[~2008-10-14 18:51 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-03 12:09 [PATCH 0/0] Add minimal omap34xx support Tony Lindgren
2008-10-03 12:09 ` [PATCH 01/05] ARM: OMAP2: Add minimal omap3430 support Tony Lindgren
2008-10-03 12:09   ` [PATCH 02/05] ARM: OMAP3: Add minimal Beagle board support Tony Lindgren
2008-10-03 12:09     ` [PATCH 03/05] ARM: OMAP3: Add Beagle defconfig Tony Lindgren
2008-10-03 12:09       ` [PATCH 04/05] ARM: OMAP2: Add support for the Gumstix Overo board (rev 3) Tony Lindgren
2008-10-03 12:09         ` [PATCH 05/05] ARM: OMAP2: defconfig " Tony Lindgren
2008-10-03 12:50         ` [PATCH 04/05] ARM: OMAP2: Add support " Tony Lindgren
2008-10-06 14:38           ` Tony Lindgren
2008-10-08  8:21       ` [PATCH 03/05] ARM: OMAP3: Add Beagle defconfig, v2 Tony Lindgren
2008-10-09 14:51     ` [PATCH 02/05] ARM: OMAP3: Add minimal Beagle board support Russell King - ARM Linux
2008-10-10  8:51       ` Tony Lindgren
2008-10-05  8:01   ` [PATCH 01/05] ARM: OMAP2: Add minimal omap3430 support Tony Lindgren
2008-10-06 14:35     ` Tony Lindgren
2008-10-08  8:19   ` [PATCH 01/05] ARM: OMAP2: Add minimal omap3430 support, v2 Tony Lindgren
2008-10-09 14:47   ` [PATCH 01/05] ARM: OMAP2: Add minimal omap3430 support Russell King - ARM Linux
2008-10-09 15:09     ` Tony Lindgren
2008-10-03 15:52 ` [PATCH 0/0] Add minimal omap34xx support twebb
2008-10-04  7:05   ` Tony Lindgren
2008-10-04 12:42     ` twebb
2008-10-04 20:37       ` Felipe Balbi
2008-10-09 14:54     ` Russell King - ARM Linux
2008-10-09 15:17       ` Tony Lindgren
2008-10-10  7:32         ` Russell King - ARM Linux
2008-10-10  9:15           ` [PATCH] ARM: OMAP3: Add basic board support for OMAP LDP (Re: [PATCH 0/0] Add minimal omap34xx support) Tony Lindgren
2008-10-10  9:25             ` [PATCH] ARM: OMAP3: Add default kernel config " Tony Lindgren
2008-10-10 11:35               ` git pull request for minimal omap3 support one more time Tony Lindgren
2008-10-13 13:32                 ` Russell King - ARM Linux
2008-10-14 17:19                   ` Tony Lindgren
2008-10-14 18:51                     ` Russell King - ARM Linux [this message]
2008-10-14 20:35                       ` Tony Lindgren
2008-10-14 20:55                         ` Tony Lindgren
2008-10-15  6:02                     ` Jarkko Nikula
2008-10-15 18:34                       ` Tony Lindgren
2008-10-08  7:50 ` git pull request for minimal omap3 support (Re: [PATCH 0/0] Add minimal omap34xx support) Tony Lindgren
2008-10-08  8:12   ` Tony Lindgren
2008-10-08 14:58     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081014185100.GA20627@flint.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-omap@vger.kernel.org \
    --cc=taliaferro62@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).