From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <me@felipebalbi.com>
Cc: David Brownell <david-b@pacbell.net>,
Paul Walmsley <paul@pwsan.com>,
linux-omap@vger.kernel.org, Felipe Balbi <felipe.balbi@nokia.com>
Subject: Re: [PATCH 1/3] clk: introduce omap_clk_associate
Date: Tue, 14 Oct 2008 13:59:26 -0700 [thread overview]
Message-ID: <20081014205925.GK8150@atomide.com> (raw)
In-Reply-To: <20081014180634.GL20247@frodo>
* Felipe Balbi <me@felipebalbi.com> [081014 12:31]:
> On Tue, Oct 14, 2008 at 10:47:44AM -0700, David Brownell wrote:
> > On Tuesday 14 October 2008, Felipe Balbi wrote:
> > > I didn't quite get you here. The idea of mmc_fck is so that
> > >
> > > clk_get(dev, "mmc_fck");
> > >
> > > works fine and returns the correct clock. If we have several fck and ick
> > > function names, how will we clk_get() the right one ??
> >
> > If "dev" is an MMC device, there's no way to confuse
> > its "fck" and "ick" with those for, say, I2C. Right?
> > That's the whole point of associating logical clock
> > names with the device.
> >
> > And as Paul noted, if a device has several such clocks,
> > then it needs several such names.
>
> hmm... that's true. Forgot about matching dev as well :-p
> hehehe. Makes sense to me, let's use fclk and iclk then :-)
>
> The main idea then would be that clk(dev, "iclk") translates to english
> into "get me the interface clock of mmc device" (when dev is an mmc
> device, of course).
And that we can use same naming in the driver no matter which omap :)
Tony
next prev parent reply other threads:[~2008-10-14 20:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-06 22:47 [PATCH 0/3] omap_clk_associate Felipe Balbi
2008-10-06 22:47 ` [PATCH 1/3] clk: introduce omap_clk_associate Felipe Balbi
2008-10-06 22:47 ` [PATCH 2/3] clk: use clk_associate for musb driver Felipe Balbi
2008-10-06 22:47 ` [PATCH 3/3] clk: use clk_associate on watchdog driver Felipe Balbi
2008-10-14 17:08 ` [PATCH 1/3] clk: introduce omap_clk_associate Paul Walmsley
2008-10-14 17:29 ` Felipe Balbi
2008-10-14 17:47 ` David Brownell
2008-10-14 18:06 ` Felipe Balbi
2008-10-14 20:59 ` Tony Lindgren [this message]
2008-10-14 21:09 ` Igor Stoppa
2008-10-14 21:24 ` Tony Lindgren
2008-10-14 21:28 ` Felipe Balbi
2008-10-15 6:21 ` Högander Jouni
2008-10-15 7:49 ` Paul Walmsley
2008-10-15 12:56 ` Woodruff, Richard
2008-10-15 13:03 ` Högander Jouni
2008-10-15 13:08 ` Paul Walmsley
2008-10-15 22:42 ` Woodruff, Richard
2008-10-15 12:45 ` Woodruff, Richard
2008-10-16 9:02 ` Paul Walmsley
-- strict thread matches above, loose matches on Subject: below --
2008-10-25 19:55 Felipe Balbi
2008-10-25 20:03 ` Felipe Balbi
2008-10-28 1:28 ` Felipe Balbi
2008-11-06 0:53 ` Felipe Balbi
2008-10-25 19:58 Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081014205925.GK8150@atomide.com \
--to=tony@atomide.com \
--cc=david-b@pacbell.net \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox