From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 1/3] clk: introduce omap_clk_associate Date: Tue, 14 Oct 2008 13:59:26 -0700 Message-ID: <20081014205925.GK8150@atomide.com> References: <1223333252-25687-1-git-send-email-me@felipebalbi.com> <20081014172921.GJ20247@frodo> <200810141047.44803.david-b@pacbell.net> <20081014180634.GL20247@frodo> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-01-bos.mailhop.org ([63.208.196.178]:51436 "EHLO mho-01-bos.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752522AbYJNU7g (ORCPT ); Tue, 14 Oct 2008 16:59:36 -0400 Content-Disposition: inline In-Reply-To: <20081014180634.GL20247@frodo> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Felipe Balbi Cc: David Brownell , Paul Walmsley , linux-omap@vger.kernel.org, Felipe Balbi * Felipe Balbi [081014 12:31]: > On Tue, Oct 14, 2008 at 10:47:44AM -0700, David Brownell wrote: > > On Tuesday 14 October 2008, Felipe Balbi wrote: > > > I didn't quite get you here. The idea of mmc_fck is so that > > > > > > clk_get(dev, "mmc_fck"); > > > > > > works fine and returns the correct clock. If we have several fck and ick > > > function names, how will we clk_get() the right one ?? > > > > If "dev" is an MMC device, there's no way to confuse > > its "fck" and "ick" with those for, say, I2C. Right? > > That's the whole point of associating logical clock > > names with the device. > > > > And as Paul noted, if a device has several such clocks, > > then it needs several such names. > > hmm... that's true. Forgot about matching dev as well :-p > hehehe. Makes sense to me, let's use fclk and iclk then :-) > > The main idea then would be that clk(dev, "iclk") translates to english > into "get me the interface clock of mmc device" (when dev is an mmc > device, of course). And that we can use same naming in the driver no matter which omap :) Tony