From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Felipe Balbi <me@felipebalbi.com>
Cc: linux-omap@vger.kernel.org, Felipe Balbi <felipe.balbi@nokia.com>
Subject: Re: [PATCH 1/7] input: lm8323: get rid of global pdata pointer
Date: Thu, 16 Oct 2008 00:10:57 -0400 [thread overview]
Message-ID: <20081016041057.GC16860@anvil.corenet.prv> (raw)
In-Reply-To: <1224020397-2842-2-git-send-email-me@felipebalbi.com>
Hi Felipe,
On Wed, Oct 15, 2008 at 12:39:51AM +0300, Felipe Balbi wrote:
> From: Felipe Balbi <felipe.balbi@nokia.com>
>
> pdata is only used during probe to initialize a few fields
> from lm8323 device structure. Moving pdata pointer to probe
> won't harm anybody.
>
I don't think I have these drivers. I also think that they should
depend on GPIOLIB (I noticed that OMAP selects GPIOLIB but I think
ecplicit dependency should still be present).
--
Dmitry
next prev parent reply other threads:[~2008-10-16 4:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-14 21:39 [PATCH 0/7] updates to few nokia drivers Felipe Balbi
2008-10-14 21:39 ` [PATCH 1/7] input: lm8323: get rid of global pdata pointer Felipe Balbi
2008-10-14 21:39 ` [PATCH 2/7] input: tsc2005: move to gpiolib Felipe Balbi
2008-10-14 21:39 ` [PATCH 3/7] i2c: lp5521: remove dead code Felipe Balbi
2008-10-14 21:39 ` [PATCH 4/7] i2c: lp5521: cosmetic fixes Felipe Balbi
2008-10-14 21:39 ` [PATCH 5/7] i2c: lp5521: simplify mode setting Felipe Balbi
2008-10-14 21:39 ` [PATCH 6/7] i2c: lp5521: move to LED framework Felipe Balbi
2008-10-14 21:39 ` [PATCH 7/7] leds: lp5521: move to drivers/leds Felipe Balbi
2008-10-14 23:20 ` [PATCH 2/7] input: tsc2005: move to gpiolib David Brownell
2008-10-15 7:43 ` Felipe Balbi
2008-10-15 10:21 ` Felipe Balbi
2008-10-16 4:10 ` Dmitry Torokhov [this message]
2008-10-16 8:39 ` [PATCH 1/7] input: lm8323: get rid of global pdata pointer Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081016041057.GC16860@anvil.corenet.prv \
--to=dmitry.torokhov@gmail.com \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox