Re: [PATCH 01/04] OMAP3 SRF: Generic shared resource f/w

[David Brownell <david-b@pacbell.net>]

On Thursday 16 October 2008, Rajendra Nayak wrote:
> +       /* Function to change the level of the resource */
> +       int (*change_level)(struct shared_resource *res, u32 target_level);
> +       /* Function to validate the requested level of the resource */
> +       int (*validate_level)(struct shared_resource *res, u32 target_level);

What is a "target_level" supposed to represent?  Are they
even comparable, in the senses that

  (a) "42" for one resource is the same as "42" for another?
  (b) "42" includes "41", "40", etc?

There's no documentation at all on what seems to be a
fairly fundamental concept.  Or on the rest of it either;
the call syntax information is no real help.  What kind
of "resource" is involved, that might need a "level"?

Also, I suspect a flat namespace for all resources will
be a net lose.  Why isn't it scoped by devices, so that
device-relative "logical names" can be used instead of
requiring what have tended to be platform-specific and
very mutable "physical names"?  I notice that the call
to request a resource is already device-scoped ...

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html