From: David Brownell <david-b@pacbell.net>
To: linux-omap@vger.kernel.org
Subject: Re: [patch 2.6.27-omap-git+ 6/5] twl4030 MMC card detction
Date: Thu, 16 Oct 2008 15:33:28 -0700 [thread overview]
Message-ID: <200810161533.28320.david-b@pacbell.net> (raw)
In-Reply-To: <200810141201.43612.david-b@pacbell.net>
On Tuesday 14 October 2008, David Brownell wrote:
> Replace stubbed-out card-detect support for twl4030 GPIOs with
> a simpler platform_data mechanism. As before, no current users.
> Sanity tested by enabling this on Beagle; it booted OK with
> root on MMC.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
> drivers/gpio/twl4030-gpio.c | 52 +++++++++---------------------------------
> include/linux/i2c/twl4030.h | 3 ++
> 2 files changed, 15 insertions(+), 40 deletions(-)
By the way, a minor comment: I noticed that there are also
settings in the PM_RECEIVER "dc-to-dc_GLOBAL_CFG" register
to change the card detect signal from active high (which is
the default) to active low.
This patch doesn't support such signal polarity options,
but it'd seem likely to me that some boards will need them.
Someday later than today. :)
This email is just to note this issue ... fixing it should
be trivial, there are several more bits available in that
byte which could be used to configure polarity.
- Dave
next prev parent reply other threads:[~2008-10-16 22:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 19:59 [patch 2.6.27-omap-git+ 0/5] twl4030 GPIO updates David Brownell
2008-10-14 19:01 ` [patch 2.6.27-omap-git+ 6/5] twl4030 MMC card detction David Brownell
2008-10-16 22:33 ` David Brownell [this message]
2008-10-16 21:26 ` [patch 2.6.27-omap-git+ 0/5] twl4030 GPIO updates Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810161533.28320.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox