From: David Brownell <david-b@pacbell.net>
To: Peter 'p2' De Schrijver <peter.de-schrijver@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 5/6] Generic twl4030 power script for 3430 based boards.
Date: Thu, 16 Oct 2008 16:09:47 -0700 [thread overview]
Message-ID: <200810161609.47835.david-b@pacbell.net> (raw)
In-Reply-To: <1224077854-23481-6-git-send-email-peter.de-schrijver@nokia.com>
On Wednesday 15 October 2008, Peter 'p2' De Schrijver wrote:
> --- /dev/null
> +++ b/arch/arm/mach-omap2/twl4030-generic-scripts.h
> @@ -0,0 +1,8 @@
> +#ifndef __TWL4030_GENERIC_SCRIPTS_H
> +#define __TWL4030_GENERIC_SCRIPTS_H
> +
> +#include <linux/i2c/twl4030.h>
> +
> +extern struct twl4030_power_data generic3430_t2scripts_data;
> +
> +#endif
I'd still put this decl into arch/arm/mach-omap2/pm.h, which
is already a bit of a grab-bag of PM hooks. As you noted,
having a header for a single declaration isn't the Best Way.
- Dave
next prev parent reply other threads:[~2008-10-16 23:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-15 13:37 [PATCH 0/6] Integrate the twl4030 power code into new twl4030 mfd Peter 'p2' De Schrijver
2008-10-15 13:37 ` [PATCH 1/6] Add defines and data types for twl4030 Peter 'p2' De Schrijver
2008-10-15 13:37 ` [PATCH 2/6] Move existing TWL4030 code to drivers/mfd Peter 'p2' De Schrijver
2008-10-15 13:37 ` [PATCH 3/6] Hook twl4030 power code into twl4030 core Peter 'p2' De Schrijver
2008-10-15 13:37 ` [PATCH 4/6] 3430sdp and ldp use custom twl4030 power scripts Peter 'p2' De Schrijver
2008-10-15 13:37 ` [PATCH 5/6] Generic twl4030 power script for 3430 based boards Peter 'p2' De Schrijver
2008-10-15 13:37 ` [PATCH 6/6] omap3 evm, beagle and overo use the generic twl4030 script Peter 'p2' De Schrijver
2008-10-16 23:09 ` David Brownell [this message]
2008-10-17 9:10 ` [PATCH 5/6] Generic twl4030 power script for 3430 based boards Peter 'p2' De Schrijver
2008-10-17 0:18 ` [PATCH 3/6] Hook twl4030 power code into twl4030 core David Brownell
-- strict thread matches above, loose matches on Subject: below --
2008-10-20 8:37 [PATCH 0/6] Integrate the twl4030 power code into new twl4030 mfd Peter 'p2' De Schrijver
2008-10-20 8:37 ` [PATCH 1/6] Add defines and data types for twl4030 Peter 'p2' De Schrijver
2008-10-20 8:37 ` [PATCH 2/6] Move existing TWL4030 code to drivers/mfd Peter 'p2' De Schrijver
2008-10-20 8:37 ` [PATCH 3/6] Hook twl4030 power code into twl4030 core Peter 'p2' De Schrijver
2008-10-20 8:37 ` [PATCH 4/6] 3430sdp and ldp use custom twl4030 power scripts Peter 'p2' De Schrijver
2008-10-20 8:37 ` [PATCH 5/6] Generic twl4030 power script for 3430 based boards Peter 'p2' De Schrijver
2008-10-31 19:50 ` Grazvydas Ignotas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810161609.47835.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
--cc=peter.de-schrijver@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox