From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [i2c] [PATCH 6/8] i2c-omap: Mark init-only functions as __init Date: Fri, 17 Oct 2008 08:39:25 -0700 Message-ID: <20081017153925.GL15820@atomide.com> References: <1222329234-31473-1-git-send-email-tony@atomide.com> <1222329234-31473-2-git-send-email-tony@atomide.com> <1222329234-31473-3-git-send-email-tony@atomide.com> <1222329234-31473-4-git-send-email-tony@atomide.com> <1222329234-31473-5-git-send-email-tony@atomide.com> <1222329234-31473-6-git-send-email-tony@atomide.com> <1222329234-31473-7-git-send-email-tony@atomide.com> <20080929223045.GU2716@fluff.org.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="DNUSDXU7R7AVVM8C" Return-path: Received: from mho-01-bos.mailhop.org ([63.208.196.178]:61722 "EHLO mho-01-bos.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754868AbYJQPjl (ORCPT ); Fri, 17 Oct 2008 11:39:41 -0400 Content-Disposition: inline In-Reply-To: <20080929223045.GU2716@fluff.org.uk> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Ben Dooks Cc: i2c@lm-sensors.org, Paul Walmsley , linux-omap@vger.kernel.org --DNUSDXU7R7AVVM8C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline * Ben Dooks [080929 15:30]: > On Thu, Sep 25, 2008 at 10:53:52AM +0300, Tony Lindgren wrote: > > From: Paul Walmsley > > > > Mark functions called only at init time as __init. > > surely these should be __devinit in case of hotplugged-ness? Here's this one fixed. Tony > > > Signed-off-by: Paul Walmsley > > Signed-off-by: Tony Lindgren > > --- > > drivers/i2c/busses/i2c-omap.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c > > index b41431a..e71f1f2 100644 > > --- a/drivers/i2c/busses/i2c-omap.c > > +++ b/drivers/i2c/busses/i2c-omap.c > > @@ -154,7 +154,7 @@ static inline u16 omap_i2c_read_reg(struct omap_i2c_dev *i2c_dev, int reg) > > return __raw_readw(i2c_dev->base + reg); > > } > > > > -static int omap_i2c_get_clocks(struct omap_i2c_dev *dev) > > +static int __init omap_i2c_get_clocks(struct omap_i2c_dev *dev) > > { > > if (cpu_is_omap16xx() || cpu_class_is_omap2()) { > > dev->iclk = clk_get(dev->dev, "i2c_ick"); > > @@ -697,7 +697,7 @@ static const struct i2c_algorithm omap_i2c_algo = { > > .functionality = omap_i2c_func, > > }; > > > > -static int > > +static int __init > > omap_i2c_probe(struct platform_device *pdev) > > { > > struct omap_i2c_dev *dev; > > -- > > 1.5.6.rc3.21.g8c6b5 > > > > > > _______________________________________________ > > i2c mailing list > > i2c@lm-sensors.org > > http://lists.lm-sensors.org/mailman/listinfo/i2c > > -- > Ben (ben@fluff.org, http://www.fluff.org/) > > 'a smiley only costs 4 bytes' --DNUSDXU7R7AVVM8C Content-Type: text/x-diff; charset=us-ascii Content-Disposition: inline; filename="0006-i2c-omap-Mark-init-only-functions-as-__init.patch" >>From 168065ac952d019a1a578c2cdc46df4ef01044c2 Mon Sep 17 00:00:00 2001 From: Paul Walmsley Date: Fri, 17 Oct 2008 07:44:58 -0700 Subject: [PATCH] i2c-omap: Mark init-only functions as __init Mark functions called only at init time as __init. Signed-off-by: Paul Walmsley Signed-off-by: Tony Lindgren --- drivers/i2c/busses/i2c-omap.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 5dd8a24..018d284 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -154,7 +154,7 @@ static inline u16 omap_i2c_read_reg(struct omap_i2c_dev *i2c_dev, int reg) return __raw_readw(i2c_dev->base + reg); } -static int omap_i2c_get_clocks(struct omap_i2c_dev *dev) +static int __devinit omap_i2c_get_clocks(struct omap_i2c_dev *dev) { if (cpu_is_omap16xx() || cpu_class_is_omap2()) { dev->iclk = clk_get(dev->dev, "i2c_ick"); @@ -692,7 +692,7 @@ static const struct i2c_algorithm omap_i2c_algo = { .functionality = omap_i2c_func, }; -static int +static int __devinit omap_i2c_probe(struct platform_device *pdev) { struct omap_i2c_dev *dev; -- 1.5.6.rc3.21.g8c6b5 --DNUSDXU7R7AVVM8C--