From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <me@felipebalbi.com>
Cc: David Brownell <david-b@pacbell.net>, linux-omap@vger.kernel.org
Subject: Re: [patch] ehci-omap: (mostly) cosmetic cleanups
Date: Fri, 17 Oct 2008 14:27:38 -0700 [thread overview]
Message-ID: <20081017212738.GV15820@atomide.com> (raw)
In-Reply-To: <20081003080154.GE10743@frodo>
* Felipe Balbi <me@felipebalbi.com> [081003 01:02]:
> On Fri, Oct 03, 2008 at 12:03:33AM -0700, David Brownell wrote:
> > From: David Brownell <dbrownell@users.sourceforge.net>
> >
> > Various cleanups to the OMAP EHCI bus glue:
> >
> > - Whitespace fixes.
> >
> > - Busy-wait loops should really have timeouts, but lacking
> > that ... at least cpu_relax() in the body.
> >
> > - Debug messages should end with newlines, so they don't
> > break the next message; should not embed newlines; and
> > should otherwise be clean and correctly spelled.
> >
> > - The probe() method should have initialized the SBRN value,
> > so the driver didn't report "USB 0.0 started".
> >
> > - The MODULE_ALIAS() was missing its "platform:" prefix;
> > doing it right means the module could hotplug/coldplug.
> >
> > No real functional change except for the hotplug/coldplug thing.
>
> I actually sent this patch (besides SBRN init) way back in time but
> Vikram and Anand (??) asked to hold on that patch since some patches
> would come from TI for ehci and ohci.
>
> Never saw those patches till now.
Pushing this today anyways, seems like some good fixes.
Tony
prev parent reply other threads:[~2008-10-17 21:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 7:03 [patch] ehci-omap: (mostly) cosmetic cleanups David Brownell
2008-10-03 8:01 ` Felipe Balbi
2008-10-17 21:27 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081017212738.GV15820@atomide.com \
--to=tony@atomide.com \
--cc=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox