Re: [PATCH] i2c: omap: highspeed only over 1000mhz

Tony Lindgren
2008-10-20T15:15:27Z

* Felipe Balbi <felipe.balbi@nokia.com> [081020 03:27]:
> up to 1000khz it's Fast Mode+, not highspeed.

Have you tested this? To me it seems this code is needed for
dev->speed > 400, and the comment may be wrong.

Tony

> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
> drivers/i2c/busses/i2c-omap.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index a999606..53d6244 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -296,7 +296,7 @@ static int omap_i2c_init(struct omap_i2c_dev *dev)
> psc = psc - 1;
>
> /* If configured for High Speed */
> - if (dev->speed > 400) {
> + if (dev->speed > 1000) {
> /* For first phase of HS mode */
> fsscll = internal_clk / (400 * 2) - 6;
> fssclh = internal_clk / (400 * 2) - 6;
> --
> 1.6.0.2.307.gc427
>
> --
> balbi