From: Tony Lindgren <tony@atomide.com>
To: Adrian Hunter <ext-adrian.hunter@nokia.com>
Cc: linux-omap Mailing List <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 1/3] ARM: OMAP: hsmmc requires data reset after data timeout
Date: Tue, 28 Oct 2008 09:59:15 -0700 [thread overview]
Message-ID: <20081028165914.GH7539@atomide.com> (raw)
In-Reply-To: <4906D437.9000607@nokia.com>
* Adrian Hunter <ext-adrian.hunter@nokia.com> [081028 01:51]:
> Adrian Hunter wrote:
>> According to TRM a software reset SRD after data timeout
>> is required.
>>
>> Signed-off-by: Adrian Hunter <ext-adrian.hunter@nokia.com>
>> ---
>> drivers/mmc/host/omap_hsmmc.c | 5 +++++
>> 1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
>> index 00b1b68..8fb677e 100644
>> --- a/drivers/mmc/host/omap_hsmmc.c
>> +++ b/drivers/mmc/host/omap_hsmmc.c
>> @@ -417,6 +417,11 @@ static irqreturn_t mmc_omap_irq(int irq, void *dev_id)
>> mmc_dma_cleanup(host);
>> else
>> host->data->error = -EILSEQ;
>> + OMAP_HSMMC_WRITE(host->base, SYSCTL,
>> + OMAP_HSMMC_READ(host->base,
>> + SYSCTL) | SRD);
>> + while (OMAP_HSMMC_READ(host->base,
>> + SYSCTL) & SRD) ;
>> end_trans = 1;
>> }
>> }
>
> Can this and my other 2 patches be applied?
OK, I really want this driver out of the l-o list and submitted via
Pierre. So only fixes at this point.. But I guess these can be
considered fixes, so I'll push them.
BTW, I'll have some patches coming up for the hsmmc.c init to prepare
that for mainline.
Regards,
Tony
prev parent reply other threads:[~2008-10-28 16:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-16 13:37 [PATCH 1/3] ARM: OMAP: hsmmc requires data reset after data timeout Adrian Hunter
2008-10-28 8:58 ` Adrian Hunter
2008-10-28 16:59 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081028165914.GH7539@atomide.com \
--to=tony@atomide.com \
--cc=ext-adrian.hunter@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox