* [PATCH 1/3] ARM: OMAP: hsmmc requires data reset after data timeout
@ 2008-10-16 13:37 Adrian Hunter
2008-10-28 8:58 ` Adrian Hunter
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Hunter @ 2008-10-16 13:37 UTC (permalink / raw)
To: linux-omap Mailing List
According to TRM a software reset SRD after data timeout
is required.
Signed-off-by: Adrian Hunter <ext-adrian.hunter@nokia.com>
---
drivers/mmc/host/omap_hsmmc.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 00b1b68..8fb677e 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -417,6 +417,11 @@ static irqreturn_t mmc_omap_irq(int irq, void *dev_id)
mmc_dma_cleanup(host);
else
host->data->error = -EILSEQ;
+ OMAP_HSMMC_WRITE(host->base, SYSCTL,
+ OMAP_HSMMC_READ(host->base,
+ SYSCTL) | SRD);
+ while (OMAP_HSMMC_READ(host->base,
+ SYSCTL) & SRD) ;
end_trans = 1;
}
}
--
1.5.4.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/3] ARM: OMAP: hsmmc requires data reset after data timeout
2008-10-16 13:37 [PATCH 1/3] ARM: OMAP: hsmmc requires data reset after data timeout Adrian Hunter
@ 2008-10-28 8:58 ` Adrian Hunter
2008-10-28 16:59 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Hunter @ 2008-10-28 8:58 UTC (permalink / raw)
To: Tony Lindgren; +Cc: linux-omap Mailing List
Adrian Hunter wrote:
> According to TRM a software reset SRD after data timeout
> is required.
>
> Signed-off-by: Adrian Hunter <ext-adrian.hunter@nokia.com>
> ---
> drivers/mmc/host/omap_hsmmc.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index 00b1b68..8fb677e 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -417,6 +417,11 @@ static irqreturn_t mmc_omap_irq(int irq, void *dev_id)
> mmc_dma_cleanup(host);
> else
> host->data->error = -EILSEQ;
> + OMAP_HSMMC_WRITE(host->base, SYSCTL,
> + OMAP_HSMMC_READ(host->base,
> + SYSCTL) | SRD);
> + while (OMAP_HSMMC_READ(host->base,
> + SYSCTL) & SRD) ;
> end_trans = 1;
> }
> }
Can this and my other 2 patches be applied?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/3] ARM: OMAP: hsmmc requires data reset after data timeout
2008-10-28 8:58 ` Adrian Hunter
@ 2008-10-28 16:59 ` Tony Lindgren
0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2008-10-28 16:59 UTC (permalink / raw)
To: Adrian Hunter; +Cc: linux-omap Mailing List
* Adrian Hunter <ext-adrian.hunter@nokia.com> [081028 01:51]:
> Adrian Hunter wrote:
>> According to TRM a software reset SRD after data timeout
>> is required.
>>
>> Signed-off-by: Adrian Hunter <ext-adrian.hunter@nokia.com>
>> ---
>> drivers/mmc/host/omap_hsmmc.c | 5 +++++
>> 1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
>> index 00b1b68..8fb677e 100644
>> --- a/drivers/mmc/host/omap_hsmmc.c
>> +++ b/drivers/mmc/host/omap_hsmmc.c
>> @@ -417,6 +417,11 @@ static irqreturn_t mmc_omap_irq(int irq, void *dev_id)
>> mmc_dma_cleanup(host);
>> else
>> host->data->error = -EILSEQ;
>> + OMAP_HSMMC_WRITE(host->base, SYSCTL,
>> + OMAP_HSMMC_READ(host->base,
>> + SYSCTL) | SRD);
>> + while (OMAP_HSMMC_READ(host->base,
>> + SYSCTL) & SRD) ;
>> end_trans = 1;
>> }
>> }
>
> Can this and my other 2 patches be applied?
OK, I really want this driver out of the l-o list and submitted via
Pierre. So only fixes at this point.. But I guess these can be
considered fixes, so I'll push them.
BTW, I'll have some patches coming up for the hsmmc.c init to prepare
that for mainline.
Regards,
Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-10-28 16:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-16 13:37 [PATCH 1/3] ARM: OMAP: hsmmc requires data reset after data timeout Adrian Hunter
2008-10-28 8:58 ` Adrian Hunter
2008-10-28 16:59 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox