Re: [PATCH 3/4] HSMMC: Add support for the second controller

[David Brownell <david-b@pacbell.net>]

On Thursday 30 October 2008, Tony Lindgren wrote:
> @@ -212,7 +212,7 @@ static void __init overo_init(void)
>         omap_board_config = overo_config;
>         omap_board_config_size = ARRAY_SIZE(overo_config);
>         omap_serial_init();
> -       hsmmc_init();
> +       hsmmc_init(HSMMC1);

Overo has its SDIO WLAN chip (libertas) hard wired to the second controller,
as I understand things ... or maybe it's the third one.  :)

Related:  shouldn't hsmmc_init() accept a set of params, maybe even a struct,
describing how each controller is wired?

	- which controller (1, 2, 3)
	- how many data wires are used (1, 4, 8)
	- supported voltages (mask)
	- card detect gpio (or negative) ... assume gpio_to_irq(gpio) works
	- write protect gpio (or negative)
	- callback for updating the voltages

That would support more complete functionality ... and get away from
the current hard-wiring of most of those parameters.

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html