public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Steve Sakoman <sakoman@gmail.com>
Cc: linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 3/4] HSMMC: Add support for the second controller
Date: Fri, 31 Oct 2008 03:00:24 -0700	[thread overview]
Message-ID: <200810310300.24515.david-b@pacbell.net> (raw)
In-Reply-To: <5e088bd90810302105n1132c280ga39179c057e55c3f@mail.gmail.com>

On Thursday 30 October 2008, Steve Sakoman wrote:
> > Overo has its SDIO WLAN chip (libertas) hard wired to the second controller,
> > as I understand things ... or maybe it's the third one.  :)
> 
> Correct!  The wi2wi chip is connected to mmc2 with a 4 bit data path.

With the appended patch on top of Tony's four, I get:

 mmc1: new SDIO card at address 0001
 firmware: requesting sd8686_helper.bin
 ...
 libertas: can't load helper firmware
 libertas: failed to load helper firmware
 libertas_sdio: probe of mmc1:0001:1 failed with error -2

So, progress.  What's the best place to get that stuff?
Do we know that this driver behaves with SDIO yet?

- dave


---
 arch/arm/mach-omap2/board-overo.c |    2 +-
 arch/arm/mach-omap2/hsmmc.c       |    1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

--- a/arch/arm/mach-omap2/board-overo.c
+++ b/arch/arm/mach-omap2/board-overo.c
@@ -214,7 +214,7 @@ static void __init overo_init(void)
 	omap_board_config = overo_config;
 	omap_board_config_size = ARRAY_SIZE(overo_config);
 	omap_serial_init();
-	hsmmc_init(HSMMC1);
+	hsmmc_init(HSMMC1 | HSMMC2);
 	usb_musb_init();
 	usb_ehci_init();
 	overo_flash_init();
--- a/arch/arm/mach-omap2/hsmmc.c
+++ b/arch/arm/mach-omap2/hsmmc.c
@@ -340,6 +340,7 @@ static struct omap_mmc_platform_data mmc
 static struct omap_mmc_platform_data mmc2_data = {
 	.nr_slots			= 1,
 	.slots[0] = {
+		.wire4			= 1,
 		.set_power		= hsmmc2_set_power,
 		.ocr_mask		= MMC_VDD_27_28 | MMC_VDD_28_29 |
 					  MMC_VDD_29_30 | MMC_VDD_30_31 |
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2008-10-31 10:00 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-31  2:04 [PATCH 0/4] Init updates for hsmmc, also second controller Tony Lindgren
2008-10-31  2:04 ` [PATCH 1/4] HSMMC: Make hsmmc use omap_ctrl_read/write and existing defines Tony Lindgren
2008-10-31  2:04   ` [PATCH 2/4] HSMMC: Fix voltage defines, make card detect gpio controller specific Tony Lindgren
2008-10-31  2:04     ` [PATCH 3/4] HSMMC: Add support for the second controller Tony Lindgren
2008-10-31  2:04       ` [PATCH 4/4] HSMMC: Misc clean-up for hsmmc init Tony Lindgren
2008-10-31  3:12       ` [PATCH 3/4] HSMMC: Add support for the second controller David Brownell
2008-10-31  3:39         ` Tony Lindgren
2008-10-31  6:41           ` David Brownell
2008-10-31 16:35             ` Tony Lindgren
2008-10-31  4:05         ` Steve Sakoman
2008-10-31 10:00           ` David Brownell [this message]
2008-10-31 23:35             ` Steve Sakoman
2008-11-01  0:36               ` David Brownell
2008-11-01  2:31                 ` Felipe Balbi
2008-11-01  2:50                 ` Steve Sakoman
2008-11-01  3:02                   ` David Brownell
2008-11-01  3:11                     ` Steve Sakoman
2008-11-03 22:54             ` Steve Sakoman
2008-11-03 23:22               ` Tony Lindgren
2008-11-03 23:36               ` Steve Sakoman
2008-11-05 23:54                 ` David Brownell
2008-11-06  3:32                   ` Tony Lindgren
2008-11-06  7:09                     ` David Brownell
2008-11-06 17:04                       ` Tony Lindgren
2008-11-06 20:19                         ` Grazvydas Ignotas
2008-11-07  5:54                           ` David Brownell
2008-11-07  9:36                             ` Grazvydas Ignotas
2008-11-10 10:36                               ` Grazvydas Ignotas
2008-11-12 22:11                                 ` Tony Lindgren
2008-11-06 20:52                         ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810310300.24515.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=linux-omap@vger.kernel.org \
    --cc=sakoman@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox