From: Lauri Leukkunen <lauri.leukkunen@nokia.com>
To: ext Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP: Use omap_rev() instead of system_rev
Date: Fri, 31 Oct 2008 15:30:49 +0200 [thread overview]
Message-ID: <20081031133049.GA23185@pure.research.nokia.com> (raw)
In-Reply-To: <20081031003438.GA13227@atomide.com>
On 30/10/08 17:34 -0700, ext Tony Lindgren wrote:
> * Lauri Leukkunen <lauri.leukkunen@nokia.com> [081030 16:29]:
> > system_rev is meant for board revision, this patch changes
> > all relevant instances to use the new omap_rev() function
> > liberating system_rev to be used with ATAG_REVISION as it
> > has been designed.
>
> Looks good to me! Let's make sure things still work and
> I'll push it and add it to my other id.c fixes to Russsell.
Seems to work (as well as the current l-o works) on omap3, compile tested for
omap1, omap2 fails to compile for me totally (also without my patch)with:
"__LINUX_ARM_ARCH__" is not defined
This is with a cs2008q3 compiler.
/lauri
next prev parent reply other threads:[~2008-10-31 13:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 23:28 [RFC] Change from system_rev to omap_rev() Lauri Leukkunen
2008-10-30 23:28 ` [PATCH] OMAP: Use omap_rev() instead of system_rev Lauri Leukkunen
2008-10-31 0:34 ` Tony Lindgren
2008-10-31 13:30 ` Lauri Leukkunen [this message]
2008-10-31 14:06 ` Lauri Leukkunen
2008-10-31 14:06 ` Lauri Leukkunen
2008-11-06 3:21 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2008-11-01 11:07 Cleaned up version of system_rev to omap_rev() Lauri Leukkunen
2008-11-01 11:07 ` [PATCH] OMAP: Use omap_rev() instead of system_rev Lauri Leukkunen
2008-11-06 3:22 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081031133049.GA23185@pure.research.nokia.com \
--to=lauri.leukkunen@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox