Re: [PATCH 1/2] Add touchscreen support for Pandora

[Tony Lindgren <tony@atomide.com>]

* Felipe Balbi <me@felipebalbi.com> [081105 15:56]:
> On Thu, Nov 06, 2008 at 01:41:46AM +0200, Grazvydas Ignotas wrote:
> > Yes, it's more like a placeholder for future patches. I plan to add a
> > function prototype and some more GPIOs. I also plan adding another
> > board file for input stuff (board-omap3pandora-input.c), as pandora
> > has lots of GPIO buttons with full qwerty keypad, and I don't want to
> > clutter the main board file with large arrays of structures.
> > If this is not acceptable I can stuff everything into board-omap3pandora.c
> 
> I think tony has the final word here, but generally the other board
> files have the keypad stuff in the main board file (board-n800.c,
> board-3430sdp.c, board-2430sdp.c, etc)
> 
> About the defines, it's only nice to put them in the header iff you
> need to use the same define on two (or more) different files. Otherwise,
> you can make the defines local to the file that needs them :-)

Well the header should be there only if needed for other boards.

Tony