Re: [PATCH] OMAP3 powerdomains: remove RET from SGX power states list

[Tony Lindgren <tony@atomide.com>]

* Paul Walmsley <paul@pwsan.com> [081105 11:39]:
> 
> The SGX device on OMAP3 does not support retention, so remove RET from the 
> list of possible SGX power states.  Problem debugged by Richard Woodruff 
> <r-woodruff2@ti.com>.

Pushing.

Tony

> Signed-off-by: Richard Woodruff <r-woodruff2@ti.com>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> 
> diff --git a/arch/arm/mach-omap2/powerdomains34xx.h b/arch/arm/mach-omap2/powerdomains34xx.h
> index 446a1ed..edfad42 100644
> --- a/arch/arm/mach-omap2/powerdomains34xx.h
> +++ b/arch/arm/mach-omap2/powerdomains34xx.h
> @@ -255,6 +255,11 @@ static struct powerdomain dss_pwrdm = {
>  	},
>  };
>  
> +/*
> + * Although the 34XX TRM Rev K Table 4-371 notes that retention is a
> + * possible SGX powerstate, the SGX device itself does not support
> + * retention.
> + */
>  static struct powerdomain sgx_pwrdm = {
>  	.name		  = "sgx_pwrdm",
>  	.prcm_offs	  = OMAP3430ES2_SGX_MOD,
> @@ -262,7 +267,7 @@ static struct powerdomain sgx_pwrdm = {
>  	.wkdep_srcs	  = gfx_sgx_wkdeps,
>  	.sleepdep_srcs	  = cam_gfx_sleepdeps,
>  	/* XXX This is accurate for 3430 SGX, but what about GFX? */
> -	.pwrsts		  = PWRSTS_OFF_RET_ON,
> +	.pwrsts		  = PWRSTS_OFF_ON,
>  	.pwrsts_logic_ret = PWRDM_POWER_RET,
>  	.banks		  = 1,
>  	.pwrsts_mem_ret	  = {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html