Re: [PATCH 3/4] HSMMC: Add support for the second controller

[David Brownell <david-b@pacbell.net>]

On Thursday 06 November 2008, Grazvydas Ignotas wrote:
> I have another SD slot connected to MMC2 via transceiver (in addition
> to usual MMC1). I wonder how can I add support for that? The easiest
> way is to add remaining twl_mmc2_* functions mmc-twl4030.c,

I plan a followon to the patch I just sent, which will let the GPIOs
hook up more generically and remove the need for most such non-generic
functions.


> and it 
> works, but this stuff would be useless for all other boards, and I
> know you hate #ifdefs here.

It would help if you explained what needed #ifdeffing, so we
don't need to guess.  I didn't see schematics in any easily
found location on openpandora.org (that's your board?).

Do VMMC1 and GPIO-0/CD hook up to MMC1?
Do VMMC2 and GPIO-1/CD hook up to MMC2?


> Another way is to just copy mmc-twl4030.c 
> and add stuff there, but that would result in lots of code
> duplication. BTW, we also have wifi chip on MMC3.
> Any ideas?

For MMC3 you'll need to write some stuff to hook to that
controller ... currently only MMC1 and MMC2 are set up.

- Dave