public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Steve Sakoman <sakoman@gmail.com>
Cc: David Brownell <david-b@pacbell.net>, linux-omap@vger.kernel.org
Subject: Re: [patch 2.6.28-rc3-omap git] hsmmc gpio updates
Date: Fri, 7 Nov 2008 11:52:04 -0800	[thread overview]
Message-ID: <20081107195203.GI21736@atomide.com> (raw)
In-Reply-To: <5e088bd90811070619h73120f30ye7608e2aaff5e514@mail.gmail.com>

* Steve Sakoman <sakoman@gmail.com> [081107 06:19]:
> On Thu, Nov 6, 2008 at 9:15 PM, David Brownell <david-b@pacbell.net> wrote:
> > From: David Brownell <dbrownell@users.sourceforge.net>
> >
> > Rework card detect GPIO handling in the twl4030 MMC glue:  drive
> > it *only* from the hsmmc_info passed; remove most of remaining
> > "we know we're always a twl4030 GPIO" logic.
> >
> > Add write-protect switch detection support to that glue.  Stub
> > in a not-present WP GPIO into most boards.  (Beagle's is real.)
> >
> > Teach the hsmmc driver how to use the card detect and writeprotect
> > methods, and move some data structure init earlier so that when IRQs
> > come in, more of the data used by their handlers is initialized.
> >
> > Verified on Beagle (WP, card detect events) and Overo (boots, both
> > card and wlan are seen).  Beagle behaves fully, and is the model
> > to follow for the common case where the TWL4030 gpio-0 card detect
> > magic is used.
> 
> Nice work!  Overo uses TWL4030 gpio-0 for card detect (just like
> Beagle) and GPIO-54 for WP.

Yeah, looks good! Pushing.

Tony

      parent reply	other threads:[~2008-11-07 19:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-07  5:15 [patch 2.6.28-rc3-omap git] hsmmc gpio updates David Brownell
2008-11-07 14:19 ` Steve Sakoman
2008-11-07 17:50   ` David Brownell
2008-11-07 18:46     ` Steve Sakoman
2008-11-07 19:52   ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081107195203.GI21736@atomide.com \
    --to=tony@atomide.com \
    --cc=david-b@pacbell.net \
    --cc=linux-omap@vger.kernel.org \
    --cc=sakoman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox