From: Samuel Ortiz <sameo@openedhand.com>
To: David Brownell <david-b@pacbell.net>
Cc: lkml <linux-kernel@vger.kernel.org>, linux-omap@vger.kernel.org
Subject: Re: [patch 2.6.28-rc3-git] twl4030-core: allow reading entire register banks
Date: Sat, 8 Nov 2008 01:32:10 +0100 [thread overview]
Message-ID: <20081108003209.GB5993@sortiz.org> (raw)
In-Reply-To: <200811071400.04181.david-b@pacbell.net>
On Fri, Nov 07, 2008 at 02:00:03PM -0800, David Brownell wrote:
> From: David Brownell <dbrownell@users.sourceforge.net>
>
> Minor change to the TWL4030 utility interface: support reads
> of all 256 bytes in each register bank (vs just 255). This
> can help when debugging, but is otherwise a NOP.
Applied to my for-next branch.
Thanks David.
Cheers,
Samuel.
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
> drivers/mfd/twl4030-core.c | 4 ++--
> include/linux/i2c/twl4030.h | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> --- a/drivers/mfd/twl4030-core.c
> +++ b/drivers/mfd/twl4030-core.c
> @@ -233,7 +233,7 @@ extern void twl4030_power_init(struct tw
> *
> * Returns the result of operation - 0 is success
> */
> -int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, u8 num_bytes)
> +int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes)
> {
> int ret;
> int sid;
> @@ -282,7 +282,7 @@ EXPORT_SYMBOL(twl4030_i2c_write);
> *
> * Returns result of operation - num_bytes is success else failure.
> */
> -int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, u8 num_bytes)
> +int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes)
> {
> int ret;
> u8 val;
> --- a/include/linux/i2c/twl4030.h
> +++ b/include/linux/i2c/twl4030.h
> @@ -78,8 +78,8 @@ int twl4030_i2c_read_u8(u8 mod_no, u8 *v
> * IMPORTANT: For twl4030_i2c_write(), allocate num_bytes + 1
> * for the value, and populate your data starting at offset 1.
> */
> -int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, u8 num_bytes);
> -int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, u8 num_bytes);
> +int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes);
> +int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes);
>
> /*----------------------------------------------------------------------*/
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2008-11-08 0:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 22:00 [patch 2.6.28-rc3-git] twl4030-core: allow reading entire register banks David Brownell
2008-11-08 0:32 ` Samuel Ortiz [this message]
2008-11-13 21:54 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081108003209.GB5993@sortiz.org \
--to=sameo@openedhand.com \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox