From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [rft/rfc/patch-2.6.28-rc3+ 00/59] namespace cleanup patches Date: Wed, 12 Nov 2008 01:50:40 +0200 Message-ID: <20081111235039.GF23454@frodo> References: <1226444238-14614-1-git-send-email-me@felipebalbi.com> <20081111232141.GD23454@frodo> <20081111234711.GO3984@atomide.com> Reply-To: me@felipebalbi.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from ns1.siteground211.com ([209.62.36.12]:41715 "EHLO serv01.siteground211.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752020AbYKKXus (ORCPT ); Tue, 11 Nov 2008 18:50:48 -0500 Content-Disposition: inline In-Reply-To: <20081111234711.GO3984@atomide.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tony Lindgren Cc: Felipe Balbi , linux-omap@vger.kernel.org, Felipe Balbi On Tue, Nov 11, 2008 at 03:47:13PM -0800, Tony Lindgren wrote: > * Felipe Balbi [081111 15:22]: > > On Wed, Nov 12, 2008 at 12:56:19AM +0200, Felipe Balbi wrote: > > > From: Felipe Balbi > > > > > > Get rid of omap_{read,write}[bsl] defines. > > > Virtual and physical addresses usage was fixed by Russel King and > > > there's no need anymore for keeping a define to a standard kernel > > > function. Get rid of those to keep the namespace cleaner. > > > > > > Build tested with all omap defconfigs. > > > Depends on my previous "make clk fwk build again on omap1" patch. > > > > for convinience, these patches plus the clock fix for omap1 and the mmc > > fix are available at [1] > > Felipe, have you tested any of these? To me looks like you're missing > the associated ioremap before you can use __raw_read/write instead of > omap_read/write. You're right, I should at least use __raw_read/write(IO_ADDRESS(...)); I'll fix it by tomorrow and test on omap3. -- balbi