public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Suresh Rajashekara <suresh@mistralsolutions.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] Fix section mismatch warning on OSK
Date: Tue, 11 Nov 2008 16:29:24 -0800	[thread overview]
Message-ID: <20081112002923.GS3984@atomide.com> (raw)
In-Reply-To: <deb0f030811111618q5e70e18doeea15271bdb7e2e8@mail.gmail.com>

* Suresh Rajashekara <suresh@mistralsolutions.com> [081111 16:18]:
> Section mismatch warnings when compiling latest git for MACH_OMAP_OSK.
> Missing __initdata on the omap1_clk_functions.
> 
> Signed-off-by: Suresh Rajashekara <suresh@mistralsolutions.com>
> ---
>  arch/arm/mach-omap1/clock.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> diff --git a/arch/arm/mach-omap1/clock.c b/arch/arm/mach-omap1/clock.c
> index 4d0c444..aab7ab1 100644
> --- a/arch/arm/mach-omap1/clock.c
> +++ b/arch/arm/mach-omap1/clock.c
> @@ -636,7 +636,7 @@ static void __init omap1_clk_disable_unused(struct clk *clk)
>  #define omap1_clk_disable_unused NULL
>  #endif
> 
> -static struct clk_functions omap1_clk_functions = {
> +static struct clk_functions omap1_clk_functions __initdata = {
>   .clk_enable = omap1_clk_enable,
>   .clk_disable = omap1_clk_disable,
>   .clk_round_rate = omap1_clk_round_rate,

This struct cannot be __initdata, it is used by plat-omap/clock.c as
arch_clock.

Tony

      reply	other threads:[~2008-11-12  0:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-12  0:18 [PATCH] Fix section mismatch warning on OSK Suresh Rajashekara
2008-11-12  0:29 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081112002923.GS3984@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=suresh@mistralsolutions.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox