public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan McDowell <noodles@earth.li>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] Fix section mismatch warnings on some OMAP1 boards
Date: Wed, 12 Nov 2008 09:13:45 +0000	[thread overview]
Message-ID: <20081112091345.GA2853@earth.li> (raw)
In-Reply-To: <20081112003637.GU3984@atomide.com>

On Tue, Nov 11, 2008 at 04:36:38PM -0800, Tony Lindgren wrote:
> * Jonathan McDowell <noodles@earth.li> [081111 15:43]:
> > I got some section mismatch warnings when compiling latest git for
> > MACH_AMS_DELTA this evening; this seems to be due to a missing
> > __initdata on the omap_board_config_kernel. Adding it fixes the
> > warnings. I noticed that although this had been done for other OMAP1
> > boards fsample, innovator and voiceblue were all lacking it too, so I
> > fixed them up at the same time.
> 
> These cannot be __initdata as they are used by get_config() in
> plat-omap/common.c, and omap_get_config() is called in some drivers
> that could be modules.

Hmmm. Well that isn't going to work at present anyway, because the 3
members of ams_delta_config are marked __initdata.

> Let's rather just get rid of all the omap_board_config_kernel stuff
> and use platform_data instead.

Ok. I shall attempt to find time to test Felipe's USB tag removal patch.

J.

      parent reply	other threads:[~2008-11-12  9:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-11 22:57 [PATCH] Fix section mismatch warnings on some OMAP1 boards Jonathan McDowell
2008-11-12  0:36 ` Tony Lindgren
2008-11-12  2:00   ` Felipe Balbi
2008-11-12  9:13   ` Jonathan McDowell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081112091345.GA2853@earth.li \
    --to=noodles@earth.li \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox