public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [patch 2.6.28-rc2-omap] H4: fix i2c registration
@ 2008-11-01  7:38 David Brownell
  2008-11-13 21:43 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: David Brownell @ 2008-11-01  7:38 UTC (permalink / raw)
  To: linux-omap

From: David Brownell <dbrownell@users.sourceforge.net>

Registering the I2C devices on H4 boards once is enough;
remove the extra call.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
---
Mainline doesn't have the call to register the I2C adapter
along with its devices ... this has that call *plus* the call
to register just the board_info.  Seems to be the only OMAP2/3
board with this bug.

 arch/arm/mach-omap2/board-h4.c |    3 ---
 1 file changed, 3 deletions(-)

--- a/arch/arm/mach-omap2/board-h4.c
+++ b/arch/arm/mach-omap2/board-h4.c
@@ -746,9 +746,6 @@ static void __init omap_h4_init(void)
 	/* Menelaus interrupt */
 	omap_cfg_reg(W19_24XX_SYS_NIRQ);
 
-	i2c_register_board_info(1, h4_i2c_board_info,
-			ARRAY_SIZE(h4_i2c_board_info));
-
 	platform_add_devices(h4_devices, ARRAY_SIZE(h4_devices));
 	omap_board_config = h4_config;
 	omap_board_config_size = ARRAY_SIZE(h4_config);

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch 2.6.28-rc2-omap] H4: fix i2c registration
  2008-11-01  7:38 [patch 2.6.28-rc2-omap] H4: fix i2c registration David Brownell
@ 2008-11-13 21:43 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2008-11-13 21:43 UTC (permalink / raw)
  To: David Brownell; +Cc: linux-omap

* David Brownell <david-b@pacbell.net> [081101 00:38]:
> From: David Brownell <dbrownell@users.sourceforge.net>
> 
> Registering the I2C devices on H4 boards once is enough;
> remove the extra call.
> 
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
> Mainline doesn't have the call to register the I2C adapter
> along with its devices ... this has that call *plus* the call
> to register just the board_info.  Seems to be the only OMAP2/3
> board with this bug.

Pushing to l-o, not adding to upstream queue.

Tony

> 
>  arch/arm/mach-omap2/board-h4.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> --- a/arch/arm/mach-omap2/board-h4.c
> +++ b/arch/arm/mach-omap2/board-h4.c
> @@ -746,9 +746,6 @@ static void __init omap_h4_init(void)
>  	/* Menelaus interrupt */
>  	omap_cfg_reg(W19_24XX_SYS_NIRQ);
>  
> -	i2c_register_board_info(1, h4_i2c_board_info,
> -			ARRAY_SIZE(h4_i2c_board_info));
> -
>  	platform_add_devices(h4_devices, ARRAY_SIZE(h4_devices));
>  	omap_board_config = h4_config;
>  	omap_board_config_size = ARRAY_SIZE(h4_config);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-11-13 21:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-01  7:38 [patch 2.6.28-rc2-omap] H4: fix i2c registration David Brownell
2008-11-13 21:43 ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox