From: Tony Lindgren <tony@atomide.com>
To: Steve Sakoman <sakoman@gmail.com>
Cc: David Brownell <david-b@pacbell.net>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: Problems with jffs2 rootfs using 2.6.28-rc3
Date: Thu, 13 Nov 2008 13:52:48 -0800 [thread overview]
Message-ID: <20081113215242.GI3106@atomide.com> (raw)
In-Reply-To: <5e088bd90811071420l2c29a74fi32bd0ddd3d73cb93@mail.gmail.com>
* Steve Sakoman <sakoman@gmail.com> [081107 14:20]:
> On Fri, Nov 7, 2008 at 1:30 PM, David Brownell <david-b@pacbell.net> wrote:
> > On Friday 07 November 2008, Steve Sakoman wrote:
> >> On Fri, Nov 7, 2008 at 12:46 PM, David Brownell <david-b@pacbell.net> wrote:
> >> > On Friday 07 November 2008, Steve Sakoman wrote:
> >> >> I'm having little success. It used to work back in 2.6.26 timeframe
> >> >> but seems to have broken sometime during 2.6.27.
> >> >
> >> > There's a patch floating around making the omap2 NAND driver
> >> > use readsw not readsl, which might explain that problem...
> >>
> >> Do you recall where you saw that patch? Here or linux-mtd? My
> >> initial search efforts weren't successful.
> >
> > On linux-omap. Or just look at the driver to see the
> > readsl()... it's a one-liner.
>
> Yes, that one line change did indeed fix the issue!
>
> Is that patch currently in the queue somewhere?
Grr, this should be sent via the MTD list! But the driver is not there,
so pushing Juha's patch to l-o today.
Tony
> For the record:
>
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index 2ede116..d18a8c9 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -196,7 +196,7 @@ static void omap_read_buf16(struct mtd_info *mtd,
> u_char *buf, int len)
> {
> struct nand_chip *nand = mtd->priv;
>
> - __raw_readsl(nand->IO_ADDR_R, buf, len / 2);
> + readsw(nand->IO_ADDR_R, buf, len / 2);
> }
>
> /*
prev parent reply other threads:[~2008-11-13 21:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 20:09 Problems with jffs2 rootfs using 2.6.28-rc3 Steve Sakoman
2008-11-07 20:46 ` David Brownell
2008-11-07 21:21 ` Steve Sakoman
2008-11-07 21:30 ` David Brownell
2008-11-07 22:20 ` Steve Sakoman
2008-11-13 21:52 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081113215242.GI3106@atomide.com \
--to=tony@atomide.com \
--cc=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
--cc=sakoman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox