* [patch 2.6.28-rc3-git] twl4030-core: allow reading entire register banks
@ 2008-11-07 22:00 David Brownell
2008-11-08 0:32 ` Samuel Ortiz
0 siblings, 1 reply; 3+ messages in thread
From: David Brownell @ 2008-11-07 22:00 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: lkml, linux-omap
From: David Brownell <dbrownell@users.sourceforge.net>
Minor change to the TWL4030 utility interface: support reads
of all 256 bytes in each register bank (vs just 255). This
can help when debugging, but is otherwise a NOP.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
---
drivers/mfd/twl4030-core.c | 4 ++--
include/linux/i2c/twl4030.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
--- a/drivers/mfd/twl4030-core.c
+++ b/drivers/mfd/twl4030-core.c
@@ -233,7 +233,7 @@ extern void twl4030_power_init(struct tw
*
* Returns the result of operation - 0 is success
*/
-int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, u8 num_bytes)
+int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes)
{
int ret;
int sid;
@@ -282,7 +282,7 @@ EXPORT_SYMBOL(twl4030_i2c_write);
*
* Returns result of operation - num_bytes is success else failure.
*/
-int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, u8 num_bytes)
+int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes)
{
int ret;
u8 val;
--- a/include/linux/i2c/twl4030.h
+++ b/include/linux/i2c/twl4030.h
@@ -78,8 +78,8 @@ int twl4030_i2c_read_u8(u8 mod_no, u8 *v
* IMPORTANT: For twl4030_i2c_write(), allocate num_bytes + 1
* for the value, and populate your data starting at offset 1.
*/
-int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, u8 num_bytes);
-int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, u8 num_bytes);
+int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes);
+int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes);
/*----------------------------------------------------------------------*/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch 2.6.28-rc3-git] twl4030-core: allow reading entire register banks
2008-11-07 22:00 [patch 2.6.28-rc3-git] twl4030-core: allow reading entire register banks David Brownell
@ 2008-11-08 0:32 ` Samuel Ortiz
2008-11-13 21:54 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Samuel Ortiz @ 2008-11-08 0:32 UTC (permalink / raw)
To: David Brownell; +Cc: lkml, linux-omap
On Fri, Nov 07, 2008 at 02:00:03PM -0800, David Brownell wrote:
> From: David Brownell <dbrownell@users.sourceforge.net>
>
> Minor change to the TWL4030 utility interface: support reads
> of all 256 bytes in each register bank (vs just 255). This
> can help when debugging, but is otherwise a NOP.
Applied to my for-next branch.
Thanks David.
Cheers,
Samuel.
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
> drivers/mfd/twl4030-core.c | 4 ++--
> include/linux/i2c/twl4030.h | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> --- a/drivers/mfd/twl4030-core.c
> +++ b/drivers/mfd/twl4030-core.c
> @@ -233,7 +233,7 @@ extern void twl4030_power_init(struct tw
> *
> * Returns the result of operation - 0 is success
> */
> -int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, u8 num_bytes)
> +int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes)
> {
> int ret;
> int sid;
> @@ -282,7 +282,7 @@ EXPORT_SYMBOL(twl4030_i2c_write);
> *
> * Returns result of operation - num_bytes is success else failure.
> */
> -int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, u8 num_bytes)
> +int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes)
> {
> int ret;
> u8 val;
> --- a/include/linux/i2c/twl4030.h
> +++ b/include/linux/i2c/twl4030.h
> @@ -78,8 +78,8 @@ int twl4030_i2c_read_u8(u8 mod_no, u8 *v
> * IMPORTANT: For twl4030_i2c_write(), allocate num_bytes + 1
> * for the value, and populate your data starting at offset 1.
> */
> -int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, u8 num_bytes);
> -int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, u8 num_bytes);
> +int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes);
> +int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes);
>
> /*----------------------------------------------------------------------*/
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch 2.6.28-rc3-git] twl4030-core: allow reading entire register banks
2008-11-08 0:32 ` Samuel Ortiz
@ 2008-11-13 21:54 ` Tony Lindgren
0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2008-11-13 21:54 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: David Brownell, lkml, linux-omap
* Samuel Ortiz <sameo@openedhand.com> [081107 16:30]:
> On Fri, Nov 07, 2008 at 02:00:03PM -0800, David Brownell wrote:
> > From: David Brownell <dbrownell@users.sourceforge.net>
> >
> > Minor change to the TWL4030 utility interface: support reads
> > of all 256 bytes in each register bank (vs just 255). This
> > can help when debugging, but is otherwise a NOP.
> Applied to my for-next branch.
> Thanks David.
Pushing also to linux-omap while waiting for this patch to fall down
from the mainline kernel.
Tony
> Cheers,
> Samuel.
>
>
> > Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> > ---
> > drivers/mfd/twl4030-core.c | 4 ++--
> > include/linux/i2c/twl4030.h | 4 ++--
> > 2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > --- a/drivers/mfd/twl4030-core.c
> > +++ b/drivers/mfd/twl4030-core.c
> > @@ -233,7 +233,7 @@ extern void twl4030_power_init(struct tw
> > *
> > * Returns the result of operation - 0 is success
> > */
> > -int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, u8 num_bytes)
> > +int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes)
> > {
> > int ret;
> > int sid;
> > @@ -282,7 +282,7 @@ EXPORT_SYMBOL(twl4030_i2c_write);
> > *
> > * Returns result of operation - num_bytes is success else failure.
> > */
> > -int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, u8 num_bytes)
> > +int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes)
> > {
> > int ret;
> > u8 val;
> > --- a/include/linux/i2c/twl4030.h
> > +++ b/include/linux/i2c/twl4030.h
> > @@ -78,8 +78,8 @@ int twl4030_i2c_read_u8(u8 mod_no, u8 *v
> > * IMPORTANT: For twl4030_i2c_write(), allocate num_bytes + 1
> > * for the value, and populate your data starting at offset 1.
> > */
> > -int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, u8 num_bytes);
> > -int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, u8 num_bytes);
> > +int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes);
> > +int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes);
> >
> > /*----------------------------------------------------------------------*/
> >
>
> --
> Intel Open Source Technology Centre
> http://oss.intel.com/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-11-13 21:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-07 22:00 [patch 2.6.28-rc3-git] twl4030-core: allow reading entire register banks David Brownell
2008-11-08 0:32 ` Samuel Ortiz
2008-11-13 21:54 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox