From: David Brownell <david-b@pacbell.net>
To: felipe.balbi@nokia.com
Cc: ext Jouni Hogander <jouni.hogander@nokia.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP: MCSPI: Enable mcspi wake-up
Date: Tue, 18 Nov 2008 09:15:34 -0800 [thread overview]
Message-ID: <200811180915.35230.david-b@pacbell.net> (raw)
In-Reply-To: <20081118133209.GY20808@gandalf.research.nokia.com>
On Tuesday 18 November 2008, Felipe Balbi wrote:
> > +#define OMAP2_MCSPI_SYSCONFIG_SMARTIDLE (0x2 << 3)
> > +#define OMAP2_MCSPI_SYSCONFIG_ENAWAKEUP (0x1 << 2)
>
> could you follow the convention below and use (1 << offset) ??
Or even BIT(offset).
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-11-18 17:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-18 13:00 [PATCH] OMAP: MCSPI: Enable mcspi wake-up Jouni Hogander
2008-11-18 13:32 ` Felipe Balbi
2008-11-18 17:15 ` David Brownell [this message]
2008-11-18 17:19 ` Felipe Balbi
2008-11-19 7:57 ` Högander Jouni
2008-11-19 7:20 ` Högander Jouni
2008-11-19 7:48 ` [PATCH] OMAP: MCSPI: Enable mcspi wake-up v2 Jouni Hogander
2008-11-26 17:57 ` Tony Lindgren
2008-11-26 18:41 ` David Brownell
2008-11-26 22:40 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811180915.35230.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=dbrownell@users.sourceforge.net \
--cc=felipe.balbi@nokia.com \
--cc=jouni.hogander@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox