Re: [PATCH] OMAP: Switch to gpio_direction_output in OMAP_LDP.

[David Brownell <david-b@pacbell.net>]

On Thursday 20 November 2008, Stanley.Miao wrote:
> -       omap_set_gpio_direction(LCD_PANEL_QVGA_GPIO, 0);
> -       omap_set_gpio_direction(LCD_PANEL_RESET_GPIO, 0);
>         gpio_direction_output(LCD_PANEL_ENABLE_GPIO, 0);
>         gpio_direction_output(LCD_PANEL_BACKLIGHT_GPIO, 0);

Nothing does

	gpio_request(LCD_PANEL_QVGA_GPIO, "qvga something");
	gpio_request(LCD_PANEL_RESET_GPIO, "lcd reset");

And by removing the initial direction setting call (above),
behavior of at least the reset line changes:  it's no longer
pullsed low.

It'd be better to change the direction setting calls above
(setting an initial low value), and then make the calls
below use gpio_set_value().

  
>  #ifdef CONFIG_FB_OMAP_LCD_VGA
> -       omap_set_gpio_dataout(LCD_PANEL_QVGA_GPIO, 0);
> +       gpio_direction_output(LCD_PANEL_QVGA_GPIO, 0);
>  #else
> -       omap_set_gpio_dataout(LCD_PANEL_QVGA_GPIO, 1);
> +       gpio_direction_output(LCD_PANEL_QVGA_GPIO, 1);
>  #endif
> -       omap_set_gpio_dataout(LCD_PANEL_RESET_GPIO, 1);
> +       gpio_direction_output(LCD_PANEL_RESET_GPIO, 1);

Use gpio_set_value() to replace omap_set_gpio_dataout(), except
when initializing.  The reset pin *was* being toggled...

- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html