From: David Brownell <david-b@pacbell.net>
To: felipe.balbi@nokia.com
Cc: "ext Premi, Sanjeev" <premi@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] Fix section mismatch warning.
Date: Thu, 20 Nov 2008 16:14:44 -0800 [thread overview]
Message-ID: <200811201614.45094.david-b@pacbell.net> (raw)
In-Reply-To: <20081120125529.GE7476@gandalf.research.nokia.com>
On Thursday 20 November 2008, Felipe Balbi wrote:
> > > > -static struct twl4030_platform_data omap3evm_twldata = {
> > > > +static struct twl4030_platform_data __initdata omap3evm_twldata = {
> > >
> > > ... and that's incorrect in any case, since that data is used
> > > by probe() code that's doesn't sit in an init section.
>
> __initdata_or_module would do the trick for static and dynamically
> linked modules.
Not in this case. Recall there are several drivers who
would all need to be using non-hotpluggable structures ...
but since the root of their tree must be hotpluggable,
they can't work that way.
> When building it statically, we'd get a bit of
> shrinkage, right ?
Can't work that way.
next prev parent reply other threads:[~2008-11-21 0:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-19 13:52 [PATCH] Fix section mismatch warning Sanjeev Premi
2008-11-20 0:26 ` David Brownell
2008-11-20 12:44 ` Premi, Sanjeev
2008-11-20 12:55 ` Felipe Balbi
2008-11-21 0:14 ` David Brownell [this message]
2008-11-20 13:41 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811201614.45094.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=premi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox