From: Tony Lindgren <tony@atomide.com>
To: David Brownell <david-b@pacbell.net>
Cc: ext-eero.nurkkala@nokia.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH] i2c: i2c-omap: Fix BUFSTAT_REG reading
Date: Fri, 21 Nov 2008 14:03:48 -0800 [thread overview]
Message-ID: <20081121220347.GC4927@atomide.com> (raw)
In-Reply-To: <200811190934.14552.david-b@pacbell.net>
* David Brownell <david-b@pacbell.net> [081119 09:34]:
> On Wednesday 19 November 2008, Eero Nurkkala wrote:
> > On Fri, 2008-11-14 at 11:16 -0800, ext David Brownell wrote:
>
> > > But if the issue is that the 2430 version of the FIFO
> > > support works differently, please say so in the patch
> > > commend and code...
> >
> > I checked against 2420, and there was no such register
> > avaiable at all. (no 2430 TRM access)
>
> That code path couldn't be triggered on 2420; just 2430,
> which has the FIFO (as evidently needed for highspeed I2C).
>
> My default assumption would be that 2430 works just like
> OMAP3 here, but obviously someone should check the 2430
> TRM to see its I2C BUFSTAT_REG really works differently.
Yes, they seem to be the same for 2430 and 34xx. Eero, can you please
update it to use the dev->rev instead? I just pushed Paul's earlier
patches for the dev->rev.
Tony
next prev parent reply other threads:[~2008-11-21 22:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-14 8:41 [PATCH] i2c: i2c-omap: Fix BUFSTAT_REG reading ext-eero.nurkkala
2008-11-14 19:16 ` David Brownell
2008-11-19 12:12 ` Eero Nurkkala
2008-11-19 17:34 ` David Brownell
2008-11-21 22:03 ` Tony Lindgren [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-11-25 11:03 ext-eero.nurkkala
2009-01-08 13:37 ` Tony Lindgren
2008-11-25 11:02 ext-eero.nurkkala
2008-11-25 6:56 ext-eero.nurkkala
2008-11-25 7:27 ` David Brownell
2008-11-25 9:19 ` Eero Nurkkala
2008-11-25 10:01 ` David Brownell
2008-11-11 6:51 ext-eero.nurkkala
2008-11-11 9:57 ` shekhar, chandra
2008-11-10 10:46 ext-eero.nurkkala
2008-11-10 12:27 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081121220347.GC4927@atomide.com \
--to=tony@atomide.com \
--cc=david-b@pacbell.net \
--cc=ext-eero.nurkkala@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox