From: Tony Lindgren <tony@atomide.com>
To: "Woodruff, Richard" <r-woodruff2@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 2/2] OMAP2/3 GPTIMER: skip unnecessary TLDR write during non-autoreload
Date: Fri, 21 Nov 2008 14:22:32 -0800 [thread overview]
Message-ID: <20081121222232.GG4927@atomide.com> (raw)
In-Reply-To: <13B9B4C6EF24D648824FF11BE89671620365C448AB@dlee02.ent.ti.com>
* Woodruff, Richard <r-woodruff2@ti.com> [081014 12:47]:
> > omap_dm_timer_write_reg(timer, OMAP_TIMER_COUNTER_REG, load);
> > - omap_dm_timer_write_reg(timer, OMAP_TIMER_LOAD_REG, load);
> > omap_dm_timer_write_reg(timer, OMAP_TIMER_CTRL_REG, l);
> > }
>
> I seem to recall there was a missed interrupt condition which this worked around.
>
> IIRC, the original code didn't bother with the load I added back as a work around as a way to get posted mode working.
Well these seem to be working based on some quick timer tests.
Pushing so we can verify it ;)
Tony
next prev parent reply other threads:[~2008-11-21 22:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-14 17:27 [PATCH 0/2] OMAP2/3 GPTIMER: minor optimizations Paul Walmsley
2008-10-14 17:27 ` [PATCH 1/2] OMAP2/3 GPTIMER: drop redundant pending write check Paul Walmsley
2008-10-14 17:27 ` [PATCH 2/2] OMAP2/3 GPTIMER: skip unnecessary TLDR write during non-autoreload Paul Walmsley
2008-10-14 19:13 ` Woodruff, Richard
2008-11-21 22:22 ` Tony Lindgren [this message]
2008-11-21 22:53 ` Woodruff, Richard
2008-11-21 23:53 ` Tony Lindgren
2008-11-26 18:39 ` Kevin Hilman
2008-11-26 18:49 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081121222232.GG4927@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=r-woodruff2@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox