From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org,
Peter de Schrijver <peter.de-schrijver@nokia.com>
Subject: Re: [PATCH 0/3] OMAP3 clock: skip reserved FREQSEL settings
Date: Fri, 21 Nov 2008 14:27:35 -0800 [thread overview]
Message-ID: <20081121222734.GH4927@atomide.com> (raw)
In-Reply-To: <20081112183754.31228.73844.stgit@localhost.localdomain>
* Paul Walmsley <paul@pwsan.com> [081112 10:53]:
> Hello,
>
> this series fixes a bug in the OMAP3 DPLL rate rounding code that will
> attempt to program the DPLL to use an internal clock frequency that
> does not exist in the FREQSEL table in 34xx TRM 4.7.6.2. This mostly
> seems to generate warnings, but can potentially hang the system.
>
> As part of this process, improve the DPLL rate rounding algorithm to
> start from a low divider (N) and count up; this should result in fewer
> passes through the loop.
>
> Tested on 3430SDP ES2 and a custom ES3 board. Thanks to Peter de Schrijver
> <peter.de-schrijver@nokia.com> for help with these patches.
Pushing this series today to l-o.
Tony
>
>
> - Paul
>
> ---
>
> text data bss dec hex filename
> 3574155 189440 108880 3872475 3b16db vmlinux.3430sdp.orig
> 3574251 189440 108880 3872571 3b173b vmlinux.3430sdp
>
> arch/arm/mach-omap2/clock.c | 118 ++++++++++++++++++++++++-------
> arch/arm/mach-omap2/clock24xx.h | 1
> arch/arm/mach-omap2/clock34xx.h | 5 +
> arch/arm/plat-omap/include/mach/clock.h | 1
> 4 files changed, 99 insertions(+), 26 deletions(-)
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-11-21 22:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 18:50 [PATCH 0/3] OMAP3 clock: skip reserved FREQSEL settings Paul Walmsley
2008-11-12 18:50 ` [PATCH 1/3] OMAP3 clock: remove unnecessary dpll_data dereferences Paul Walmsley
2008-11-12 18:51 ` [PATCH 2/3] OMAP3 clock: optimize DPLL rate rounding algorithm Paul Walmsley
2008-11-12 18:52 ` [PATCH 3/3] OMAP3 clock: avoid invalid FREQSEL values during DPLL rate rounding Paul Walmsley
2008-11-21 22:27 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081121222734.GH4927@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=peter.de-schrijver@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox