From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: linux-omap@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: Please fix lcd_sx1.c
Date: Sun, 23 Nov 2008 16:57:48 +0000 [thread overview]
Message-ID: <20081123165748.GC17438@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20081123164618.GA17438@flint.arm.linux.org.uk>
On Sun, Nov 23, 2008 at 04:46:18PM +0000, Russell King - ARM Linux wrote:
> To me, it looks like this driver was tossed over into mainline without
> any thought - it has never been in a buildable state. Please fix or
> remove this driver from mainline.
Actually, it was buildable, until this commit:
commit b4b58f5834a023dab67201db9a626bef07bb200c
Author: Chandra Shekhar <x0044955@ti.com>
Date: Wed Oct 8 10:01:39 2008 +0300
ARM: OMAP: Allocate McBSP devices dynamically
Based on Chandra's earlier patches in linux-omap tree.
Note that omap1_mcbsp_check and omap2_mcbsp_check are no longer
needed as there's now omap_mcbsp_check_valid_id() defined.
Also some functions can now be marked __init.
Signed-off-by: Chandra Shekhar <x0044955@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
which means it's a regression and therefore needs fixing before 2.6.28.
next prev parent reply other threads:[~2008-11-23 16:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-23 16:46 Please fix lcd_sx1.c Russell King - ARM Linux
2008-11-23 16:57 ` Russell King - ARM Linux [this message]
2008-11-24 21:20 ` Tony Lindgren
2008-11-25 2:22 ` [PATCH] ARM: OMAP: Remove broken LCD driver for SX1 (Re: Please fix lcd_sx1.c) Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081123165748.GC17438@flint.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox