From: David Brownell <david-b@pacbell.net>
To: hvaibhav@ti.com
Cc: video4linux-list@redhat.com, linux-omap@vger.kernel.org,
davinci-linux-open-source-bounces@linux.davincidsp.com,
Brijesh Jadav <brijesh.j@ti.com>
Subject: Re: [PATCH 2/2] TVP514x V4L int device driver support
Date: Mon, 24 Nov 2008 02:06:37 -0800 [thread overview]
Message-ID: <200811240206.38924.david-b@pacbell.net> (raw)
In-Reply-To: <1227280923-31654-1-git-send-email-hvaibhav@ti.com>
On Friday 21 November 2008, hvaibhav@ti.com wrote:
> +static const struct i2c_device_id tvp514x_id[] = {
> + {MODULE_NAME, 0},
> + {},
> +};
Don't do that. Instead:
{ "tvp5146", 0 },
{ "tvp5147", 0 },
and so on. Maybe pass a flag there to help determine which
chip reset/init message sequence to use. (Which, hmm, I did
not see in this code, although the data sheets are clear
that the '46 needs 12 writes and the '47 needs 18 ...) Or
tell if the extra '46 registers are available, etc.
> +late_initcall(tvp514x_init);
Why is this "late" instead of normal module_init()?
It's unusual for I2C...
- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-11-24 10:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <hvaibhav@ti.com>
2008-11-21 15:22 ` [PATCH 2/2] TVP514x V4L int device driver support hvaibhav
2008-11-21 16:16 ` Hans Verkuil
2008-11-21 18:12 ` Trilok Soni
2008-11-21 19:07 ` Hiremath, Vaibhav
2008-11-21 19:11 ` David Brownell
2008-11-23 22:00 ` Hans Verkuil
2008-11-23 22:04 ` Koen Kooi
2008-11-24 6:16 ` Trilok Soni
2008-11-24 6:32 ` David Brownell
2008-11-24 7:53 ` Hans Verkuil
2008-11-24 8:53 ` Hiremath, Vaibhav
2008-11-24 8:04 ` Hans Verkuil
2008-11-24 8:43 ` Trilok Soni
2008-11-24 8:59 ` Hiremath, Vaibhav
2008-11-24 10:06 ` David Brownell [this message]
2008-11-26 17:05 ` [PATCH 2/2] TVP514x Driver with Review comments fixed hvaibhav
2008-11-26 17:48 ` Hans Verkuil
2008-12-02 15:35 ` [PATCH 2/2] TVP514x Driver with Review comments fixed [V4] hvaibhav
2008-12-02 17:20 ` Hans Verkuil
2008-12-03 3:58 ` Hiremath, Vaibhav
2008-12-02 19:29 ` David Brownell
2008-12-02 19:44 ` David Brownell
2009-05-06 18:31 ` [PATCH (V2)] TVP514x: Migration to sub-device framework hvaibhav
2009-06-14 10:14 ` Hans Verkuil
2009-06-14 12:44 ` Hans Verkuil
2009-06-14 14:32 ` tcm825x.c: migrating to sub-device framework? (was: TVP514x: Migration to sub-device framework) Hans Verkuil
2009-06-15 8:45 ` tcm825x.c: migrating to sub-device framework? Sakari Ailus
[not found] ` <200906141214.38355.hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2009-06-14 19:50 ` [PATCH (V2)] TVP514x: Migration to sub-device framework David Brownell
2008-11-24 11:23 [PATCH 2/2] TVP514x V4L int device driver support Hans Verkuil
-- strict thread matches above, loose matches on Subject: below --
2008-11-24 10:22 Hans Verkuil
2008-11-24 9:32 Hans Verkuil
2008-11-24 10:46 ` Hiremath, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811240206.38924.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=brijesh.j@ti.com \
--cc=davinci-linux-open-source-bounces@linux.davincidsp.com \
--cc=hvaibhav@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox