From: David Brownell <david-b@pacbell.net>
To: ext-eero.nurkkala@nokia.com
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] i2c: i2c-omap: Fix BUFSTAT_REG reading
Date: Tue, 25 Nov 2008 02:01:09 -0800 [thread overview]
Message-ID: <200811250201.09214.david-b@pacbell.net> (raw)
In-Reply-To: <1227604759.27458.16.camel@eenurkka-desktop>
On Tuesday 25 November 2008, Eero Nurkkala wrote:
> Shortly: Restate the introductory header and resend the patches?
Restate, and update the patch to address the issues noted inline.
You had added the
if (34xx) {
...
} else /* must be 2430 */ {
...
}
branches, but since 34xx and 2430 act the same there (per Tony's
check of the 2430 manual) ... neither the check, nor the "else"
branch, is needed.
next prev parent reply other threads:[~2008-11-25 10:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 6:56 [PATCH] i2c: i2c-omap: Fix BUFSTAT_REG reading ext-eero.nurkkala
2008-11-25 7:27 ` David Brownell
2008-11-25 9:19 ` Eero Nurkkala
2008-11-25 10:01 ` David Brownell [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-11-25 11:03 ext-eero.nurkkala
2009-01-08 13:37 ` Tony Lindgren
2008-11-25 11:02 ext-eero.nurkkala
2008-11-14 8:41 ext-eero.nurkkala
2008-11-14 19:16 ` David Brownell
2008-11-19 12:12 ` Eero Nurkkala
2008-11-19 17:34 ` David Brownell
2008-11-21 22:03 ` Tony Lindgren
2008-11-11 6:51 ext-eero.nurkkala
2008-11-11 9:57 ` shekhar, chandra
2008-11-10 10:46 ext-eero.nurkkala
2008-11-10 12:27 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811250201.09214.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=ext-eero.nurkkala@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox