[PATCH] ARM: OMAP: Extend gpio label column width in omap_gpio debugfs file

[PATCH] ARM: OMAP: Extend gpio label column width in omap_gpio debugfs file

[Jarkko Nikula]

There are already various drivers having bigger label than 10 bytes. Most
of them fit well under 20 bytes but make column width exact so that
oversized labels don't mess up output alignment.

Signed-off-by: Jarkko Nikula <jarkko.nikula@nokia.com>
---
 arch/arm/plat-omap/gpio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
index 8bb4542..821100d 100644
--- a/arch/arm/plat-omap/gpio.c
+++ b/arch/arm/plat-omap/gpio.c
@@ -1820,7 +1820,7 @@ static int dbg_gpio_show(struct seq_file *s, void *unused)
 				seq_printf(s, "MPUIO %2d ", j);
 			else
 				seq_printf(s, "GPIO %3d ", gpio);
-			seq_printf(s, "(%10s): %s %s",
+			seq_printf(s, "(%-20.20s): %s %s",
 					label,
 					is_in ? "in " : "out",
 					value ? "hi"  : "lo");
-- 
1.5.6.5

Re: [PATCH] ARM: OMAP: Extend gpio label column width in omap_gpio debugfs file

[David Brownell]

On Wednesday 12 November 2008, Jarkko Nikula wrote:
> There are already various drivers having bigger label than 10 bytes. Most
> of them fit well under 20 bytes but make column width exact so that
> oversized labels don't mess up output alignment.
> 
> Signed-off-by: Jarkko Nikula <jarkko.nikula@nokia.com>

Acked-by: David Brownell <dbrownell@users.sourceforge.net>

> ---
>  arch/arm/plat-omap/gpio.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
> index 8bb4542..821100d 100644
> --- a/arch/arm/plat-omap/gpio.c
> +++ b/arch/arm/plat-omap/gpio.c
> @@ -1820,7 +1820,7 @@ static int dbg_gpio_show(struct seq_file *s, void *unused)
>  				seq_printf(s, "MPUIO %2d ", j);
>  			else
>  				seq_printf(s, "GPIO %3d ", gpio);
> -			seq_printf(s, "(%10s): %s %s",
> +			seq_printf(s, "(%-20.20s): %s %s",
>  					label,
>  					is_in ? "in " : "out",
>  					value ? "hi"  : "lo");
> -- 
> 1.5.6.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

Re: [PATCH] ARM: OMAP: Extend gpio label column width in omap_gpio debugfs file

[Tony Lindgren]

* Jarkko Nikula <jarkko.nikula@nokia.com> [081112 00:03]:
> There are already various drivers having bigger label than 10 bytes. Most
> of them fit well under 20 bytes but make column width exact so that
> oversized labels don't mess up output alignment.

Pushing & adding to omap-upstream queue.

Tony

> Signed-off-by: Jarkko Nikula <jarkko.nikula@nokia.com>
> ---
>  arch/arm/plat-omap/gpio.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
> index 8bb4542..821100d 100644
> --- a/arch/arm/plat-omap/gpio.c
> +++ b/arch/arm/plat-omap/gpio.c
> @@ -1820,7 +1820,7 @@ static int dbg_gpio_show(struct seq_file *s, void *unused)
>  				seq_printf(s, "MPUIO %2d ", j);
>  			else
>  				seq_printf(s, "GPIO %3d ", gpio);
> -			seq_printf(s, "(%10s): %s %s",
> +			seq_printf(s, "(%-20.20s): %s %s",
>  					label,
>  					is_in ? "in " : "out",
>  					value ? "hi"  : "lo");
> -- 
> 1.5.6.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html