From: Tony Lindgren <tony@atomide.com>
To: Felipe Contreras <felipe.contreras@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] omapfb: Fix argument of blank operation.
Date: Wed, 26 Nov 2008 09:35:47 -0800 [thread overview]
Message-ID: <20081126173546.GQ11997@atomide.com> (raw)
In-Reply-To: <1227641052-6510-1-git-send-email-felipe.contreras@nokia.com>
* Felipe Contreras <felipe.contreras@nokia.com> [081125 11:24]:
> The blank operation should receive FB_BLANK_POWERDOWN, not
> VESA_POWERDOWN.
Here's my canned fbdev reply for this tread too:
Guys, please take this discussion to fbdev mailing list and cc
linux-omap list. I'm not going to push any more omap fbdev patches,
so please send the patches against mainline kernel to fbdev list.
Regards,
Tony
> Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
> ---
> drivers/video/omap/omapfb_main.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/omap/omapfb_main.c b/drivers/video/omap/omapfb_main.c
> index 3bb4247..c8db8b2 100644
> --- a/drivers/video/omap/omapfb_main.c
> +++ b/drivers/video/omap/omapfb_main.c
> @@ -348,7 +348,7 @@ static int omapfb_blank(int blank, struct fb_info *fbi)
>
> omapfb_rqueue_lock(fbdev);
> switch (blank) {
> - case VESA_NO_BLANKING:
> + case FB_BLANK_UNBLANK:
> if (fbdev->state == OMAPFB_SUSPENDED) {
> if (fbdev->ctrl->resume)
> fbdev->ctrl->resume();
> @@ -359,7 +359,7 @@ static int omapfb_blank(int blank, struct fb_info *fbi)
> do_update = 1;
> }
> break;
> - case VESA_POWERDOWN:
> + case FB_BLANK_POWERDOWN:
> if (fbdev->state == OMAPFB_ACTIVE) {
> fbdev->panel->disable(fbdev->panel);
> if (fbdev->ctrl->suspend)
> @@ -1842,7 +1842,7 @@ static int omapfb_suspend(struct platform_device *pdev, pm_message_t mesg)
> struct omapfb_device *fbdev = platform_get_drvdata(pdev);
>
> if (fbdev != NULL)
> - omapfb_blank(VESA_POWERDOWN, fbdev->fb_info[0]);
> + omapfb_blank(FB_BLANK_POWERDOWN, fbdev->fb_info[0]);
> return 0;
> }
>
> @@ -1852,7 +1852,7 @@ static int omapfb_resume(struct platform_device *pdev)
> struct omapfb_device *fbdev = platform_get_drvdata(pdev);
>
> if (fbdev != NULL)
> - omapfb_blank(VESA_NO_BLANKING, fbdev->fb_info[0]);
> + omapfb_blank(FB_BLANK_UNBLANK, fbdev->fb_info[0]);
> return 0;
> }
>
> --
> 1.6.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-11-26 17:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 19:24 [PATCH] omapfb: Fix argument of blank operation Felipe Contreras
2008-11-26 17:35 ` Tony Lindgren [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-12-04 22:45 Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081126173546.GQ11997@atomide.com \
--to=tony@atomide.com \
--cc=felipe.contreras@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox