From: Tony Lindgren <tony@atomide.com>
To: Jouni Hogander <jouni.hogander@nokia.com>,
David Brownell <david-b@pacbell.net>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP: MCSPI: Enable mcspi wake-up v2.
Date: Wed, 26 Nov 2008 09:57:10 -0800 [thread overview]
Message-ID: <20081126175709.GS11997@atomide.com> (raw)
In-Reply-To: <1227080924-11555-1-git-send-email-jouni.hogander@nokia.com>
* Jouni Hogander <jouni.hogander@nokia.com> [081118 23:48]:
> Currently mcspi wake-ups are not enabled. This might cause case where
> OMAP is not waking up on mcspi events.
Dave, I assume you're picking these for your SPI queue? Will only
apply to l-o if you ack and tell me so.
Tony
> Signed-off-by: Jouni Hogander <jouni.hogander@nokia.com>
> ---
> drivers/spi/omap2_mcspi.c | 11 +++++++++--
> 1 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/omap2_mcspi.c b/drivers/spi/omap2_mcspi.c
> index 454a271..d7e519c 100644
> --- a/drivers/spi/omap2_mcspi.c
> +++ b/drivers/spi/omap2_mcspi.c
> @@ -59,6 +59,8 @@
>
> /* per-register bitmasks: */
>
> +#define OMAP2_MCSPI_SYSCONFIG_SMARTIDLE (2 << 3)
> +#define OMAP2_MCSPI_SYSCONFIG_ENAWAKEUP (1 << 2)
> #define OMAP2_MCSPI_SYSCONFIG_AUTOIDLE (1 << 0)
> #define OMAP2_MCSPI_SYSCONFIG_SOFTRESET (1 << 1)
>
> @@ -90,6 +92,7 @@
>
> #define OMAP2_MCSPI_CHCTRL_EN (1 << 0)
>
> +#define OMAP2_MCSPI_WAKEUPENABLE_WKEN (1 << 0)
>
> /* We have 2 DMA channels per CS, one for RX and one for TX */
> struct omap2_mcspi_dma {
> @@ -884,8 +887,12 @@ static int __init omap2_mcspi_reset(struct omap2_mcspi *mcspi)
> } while (!(tmp & OMAP2_MCSPI_SYSSTATUS_RESETDONE));
>
> mcspi_write_reg(master, OMAP2_MCSPI_SYSCONFIG,
> - /* (3 << 8) | (2 << 3) | */
> - OMAP2_MCSPI_SYSCONFIG_AUTOIDLE);
> + OMAP2_MCSPI_SYSCONFIG_AUTOIDLE |
> + OMAP2_MCSPI_SYSCONFIG_ENAWAKEUP |
> + OMAP2_MCSPI_SYSCONFIG_SMARTIDLE);
> +
> + mcspi_write_reg(master, OMAP2_MCSPI_WAKEUPENABLE,
> + OMAP2_MCSPI_WAKEUPENABLE_WKEN);
>
> omap2_mcspi_set_master_mode(master);
>
> --
> 1.6.0.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-11-26 17:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-18 13:00 [PATCH] OMAP: MCSPI: Enable mcspi wake-up Jouni Hogander
2008-11-18 13:32 ` Felipe Balbi
2008-11-18 17:15 ` David Brownell
2008-11-18 17:19 ` Felipe Balbi
2008-11-19 7:57 ` Högander Jouni
2008-11-19 7:20 ` Högander Jouni
2008-11-19 7:48 ` [PATCH] OMAP: MCSPI: Enable mcspi wake-up v2 Jouni Hogander
2008-11-26 17:57 ` Tony Lindgren [this message]
2008-11-26 18:41 ` David Brownell
2008-11-26 22:40 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081126175709.GS11997@atomide.com \
--to=tony@atomide.com \
--cc=david-b@pacbell.net \
--cc=jouni.hogander@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox